[Kmymoney-devel] Review Request: Some widgets are compiled 3 times.

[Thomas Baumgart]

> On 2010-06-18 10:01:32, Alvaro Soliverez wrote:
> > I still see that make needs to be called twice before calling make install, but it is way faster than before, so it looks good from my side.
> 
> Thomas Baumgart wrote:
>     I see the same thing, but I saw it happen partially in libkdchart so I simply skipped it.
> 
> Cristian Onet wrote:
>     Then please go ahead and submit it (don't forget to reference the b.k.o entry in the commit message).
> 
> Vincent Ordy wrote:
>     For libkdchart that's a bug in automoc.  I've filled a bug report on the KDE buildsystem yesterday: https://bugs.kde.org/show_bug.cgi?id=242032
>     
>     The patch in this review request solves the problem for ${_uncritial_common_sources} but not for the 6 files of ${_critial_common_sources} when Qt Designer option is turned on.  The problem with ${_critial_common_sources} is tricky and may require to hack the automoc4's cmake macros.

The solution to fix the problem is to lift the separation of the Qt Designer widget lib and the one we use for the application. No need to hack any cmake macros. It might take some time though.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4379/#review6181
-----------------------------------------------------------


On 2010-06-18 02:45:12, Vincent Ordy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4379/
> -----------------------------------------------------------
> 
> (Updated 2010-06-18 02:45:12)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> - Remove useless library dependencies
> - Remove ${_uncritial_common_sources} from kmymoneywidgets.so and libwidgets.a.  They are both linked to libkmymoney_base.a, which is built from ${_uncritial_common_sources}.  => the ${_uncritial_common_sources} files were built 3 times.
> 
> 
> This addresses bug 242044.
>     https://bugs.kde.org/show_bug.cgi?id=242044
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/CMakeLists.txt 1139201 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/CMakeLists.txt 1139201 
> 
> Diff: http://reviewboard.kde.org/r/4379/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vincent
> 
>