[Kmymoney-devel] Review Request: KMM bug #240629 - Progress bar does not reach 100% but count does.

[Cristian Onet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4417/#review6680
-----------------------------------------------------------


We should add this patch before the stable release.

- Cristian


On 2010-06-22 12:46:36, Vincent Ordy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4417/
> -----------------------------------------------------------
> 
> (Updated 2010-06-22 12:46:36)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> - set progressbar value to 0 after a reset (reset() sets it to -1, which is
> invalid and cause this bug)
> - increment the progressbar value only when appropriate.  Some elements like <budgets> do not initialize the progressbar, but the progressbar value was incremented => the value become greater than the maximum => the progressbar is reset by Qt.
> - remove useless resets
> 
> 
> This addresses bug 240629.
>     https://bugs.kde.org/show_bug.cgi?id=240629
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1140640 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp 1140640 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragexml.cpp 1140640 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneymvccombo.cpp 1140640 
> 
> Diff: http://reviewboard.kde.org/r/4417/diff
> 
> 
> Testing
> -------
> 
> build + load 2 files w/ the progressbar timer disabled (kmymoney/kmymoney.cpp:1932) to slow down the progress
> 
> 
> Thanks,
> 
> Vincent
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100723/2a3e790f/attachment.htm