[Kmymoney-devel] Review Request: Ported kreportsview to QT4.

[Alvaro Soliverez]

On Tue, Jul 13, 2010 at 4:05 PM, Bernd Gonsior
<bernd.gonsior at googlemail.com> wrote:
> Alvaro Soliverez schrieb am 13.07.2010 02:56:
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/4601/#review6514
>> -----------------------------------------------------------
>>
>> Ship it!
>>
>>
>> Commited to SVN.
>> Once again, great work!
>>
>> - Alvaro
>
> Thank you! I'll remove/replace the remaining old qDebugs in kreportsview during the
> next days.
>
> Furthermore i have some questions regarding this task:
>
> "a bug/feature for prices report, to not show the data on the
> report charts if no price data is available."
>
> 1. Do you mean the report "Investment Price Graph"
> (see kreportsview.cpp, line 1409)?
>
Yep, that's right. If you want to take on it, I will have to write a
detailed description, because there is a lot you can break in there.
:)

> 2. Currently there are only some labels on the chart if there are no investments
> (the chart title, "balance" as label for y-axis, "time" as label for x-axis and a
> legend box with the title "legend" only). What should be shown instead of this if
> there are no investements - maybe something like "no data available" below the chart
> title?
>

I think a subtitle could be added and the legends and axis labels removed.


> 3. Should it be done by the end of July?
>
> - Bernd
>

No, this will be for after the release, since it's not critical and
things can break badly.