[Kmymoney-devel] Review Request: Ported kreportsview to QT4.

Bernd Gonsior bernd.gonsior at googlemail.com
Mon Jul 12 18:36:13 CEST 2010



> On 2010-07-12 11:12:21, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp, line 61
> > <http://reviewboard.kde.org/r/4601/diff/3/?file=30910#file30910line61>
> >
> >     programm -> program

Please excuse me, i'm a german ;-)


> On 2010-07-12 11:12:21, Alvaro Soliverez wrote:
> > /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp, line 64
> > <http://reviewboard.kde.org/r/4601/diff/3/?file=30910#file30910line64>
> >
> >     Please add some comments to the implementation to understand what and why it is doing it

Implementation commented.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4601/#review6492
-----------------------------------------------------------


On 2010-07-12 16:28:16, Bernd Gonsior wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4601/
> -----------------------------------------------------------
> 
> (Updated 2010-07-12 16:28:16)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> See inline-doc (doxygen). This patch should be tested careful before it is commited to svn.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.cpp 1148947 
>   /trunk/extragear/office/kmymoney/kmymoney/views/CMakeLists.txt 1148947 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kreportsview.h 1148947 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitem.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemgroup.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/views/tocitemreport.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4601/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100712/fc9c8a04/attachment-0001.htm 


More information about the KMyMoney-devel mailing list