[Kmymoney-devel] currency selector button label

[Jack]

On 2010.07.05 10:29, Alvaro Soliverez wrote:
> On Mon, Jul 5, 2010 at 11:10 AM, Jack  
> <ostroffjh at users.sourceforge.net> wrote:
>> While I agree with sticking with KDE standards/guidelines, as a  
>> user, I assume that "OK" means do something, and there should be a  
>> "Cancel" button if I want to quit the dialog without doing anything.  
>>  If there is an "Apply" button (in this case "Set as baseline  
>> currency") and the "OK" button never does anything and is (in my  
>> opinion) better labeled "Exit" or "Close," especially if it does not  
>> also apply the change.
> Ok. Let's change it to Close.
Thanks.

>> In this case, if you select a different currency, the "Set ..."  
>> button becomes un-grayed, and clicking "OK" really does just exit  
>> without changing the currency.
> The set base currency should apply the change immediately. Does it  
> not?
Yes, it does that (which is also what I would expect, no problem with  
that)

> That's not what I expect an "OK" button to do.
Sorry - I'm confused.  Would you expect the OK to exit WITH or WITHOUT  
applying the change?  (Assuming you have NOT clicked the "Set base  
currency" button first.)

>> Would it make sense here then to add a "Cancel" button, which  
>> becomes active at the same time the "Set ...." button does?

> > Is there a better place to discuss this - as a general KDE UI issue?

> > On 2010.07.04 20:16, Alvaro Soliverez wrote:
>>> No, we are following the KDE guideline here, as far as I can tell.  
>>> Using the standard Close button calls KDialog::reject() which in  
>>> this case is not a problem, but it might in other cases. So, I'd  
>>> rather stick with Ok.
> >
> >> On Sun, Jul 4, 2010 at 7:32 PM, Jack <ostroffjh at sbcglobal.net>  
> wrote:
>>>> The currency selector has a button now labeled "OK" where it used  
>>>> to say "Close."  Unless there is also a "Cancel" button, I think  
>>>> "Close" is more appropriate then "OK" especially if you haven't  
>>>> made any selection.  Does this seem reasonable?