[Kmymoney-devel] Can't remove payee from transaction (3.95)

[Alvaro Soliverez]

On Fri, Feb 19, 2010 at 5:16 PM, Jack <ostroffjh at users.sourceforge.net> wrote:
> On 2010.02.19 13:32, Alvaro Soliverez wrote:
>>
>> On Fri, Feb 19, 2010 at 12:47 PM, Jack <ostroffjh at users.sourceforge.net>
>> wrote:
>> > On 2010.02.19 07:20, Alvaro Soliverez wrote:
>>>>
>>>> On Thu, Feb 18, 2010 at 11:34 AM, Alvaro Soliverez
>>>> <asoliverez at gmail.com> wrote:
>>>>>
>>>>> On Thu, Feb 18, 2010 at 11:12 AM, Jack
>>>>> <ostroffjh at users.sourceforge.net> wrote:
>>
>> >> >> On 2010.02.18 01:00, Thomas Baumgart wrote:
>> >> >>> on Wednesday 17 February 2010 Alvaro Soliverez wrote:
>>>>>>>>
>>>>>>>> On Wed, Feb 17, 2010 at 2:55 PM, Jack
>>>>>>>> <ostroffjh at users.sourceforge.net wrote:
>
>>>>>>>>> For transfer transactions, I prefer not to specify a Payee.  I can
>>>>>>>>> create such a transaction with no problem.  However, when I download an OFX
>>>>>>>>> from my bank, a transfer shows up as a payment, and I used to (in 1.0) edit
>>>>>>>>> the transacion, delete the payee, change the transaction type to transfer,
>>>>>>>>> and add the other account.  In the new version, I do exactly the same thing,
>>>>>>>>> but when I save the transaction, the payee is still there.
>
>>>>>>>>> There is another minor difference between 1.0 and 3.95, although
>>>>>>>>> this is from memory since I don't have a copy of the old version installed.
>>>>>>>>> In 1.0, I had to explicitly hit ESC or click in another field when leaving
>>>>>>>>> the Payee field blank, or else it would just insert whatever payee was
>>>>>>>>> selected in the drop-down.  In 3.95, I can just tab out of a blank payee
>>>>>>>>> field - which is fine for a new transaction, but if I'm deleting a payee
>>>>>>>>> when editing a transaction, it shows a blank payee field, but it doesn't
>>>>>>>>> actually delete it, and the original payee shows up after I have saved the
>>>>>>>>> transaction.
>
>>>>>>>> This is probably a problem with the new KMyMoneyPayeeCombo. I'll
>>>>>>>> look into  it.
>
>> >> >>> Looks very similar to https://bugs.kde.org/show_bug.cgi?id=226261
>
>>>>>> This is not the same as that bug.  I am not trying to completely
>>>>>> delete the payee.  I am just trying to remove the payee from the
>>>>>> transaction. I can see this happening if the KMyMoneyPayeeCombo returns "no
>>>>>> change" rather than "changed to blank" so I think Alvaro is probably on the
>>>>>> right track.
>
>>>>> There's a condition in the code where it specifically prevents you from
>>>>> putting a blank on an existing payee. :D I have to run some tests and then
>>>>> I'll commit the fix.
>
>> >> can you try the latest svn? I added a condition to check for that case.
>
>>> Sorry but I don't see a change.  If I delete the payee in the combobox,
>>> it looks OK, but when I save the transaction, the payee is still there.
>
>> Can you specify exactly your steps? I added the condition to the focusOut
>> event, but I may have missed something.
>
> Create a new transaction leaving the payee blank.  The other details don't
> matter.  That shows it's allowed to have a missing payee.  Now edit the
> transaction, put in any payee, and save the change.  Now edit the
> transaction again, click in the payee field and erase the payee with delete
> and/or backspace keys or by clicking the clear field x icon.  Click in any
> other field just to show the payee field stays blank.  Click on the "Enter"
> icon to save the changes.  The payee field still shows the payee.
>
> Note:  I realized my first test of this was not valid since I just ran the
> new kmymoney without doing make install.  However, it is still the same
> running build/kmymoney/kmymoney.shell.  Is it safe to assume that is only
> using the svn version, and not any libraries from my installed version?  I'd
> hate to think I'm testing the new code if I'm not.
>

The steps seem to be the same I tried this morning. I even tried
editing a normal transaction and changing the payee, just to make sure
there wasn't a regression.
This is part of the widgets, which have to get installed, so I'm not
sure it will work just running from kmymoney.shell.