[Kmymoney-devel] Review Request: Updates to CSV Plugin

[Allan Anderson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6238/
-----------------------------------------------------------

Review request for kmymoney.


Summary
-------

Wish-list Items:
  Addition of UI text delimiter (" or ').
  Addition of handling of line breaks within payee and memo fields.
  Addition of handling of amount sign via a code in another field.
Bug fixes:
  A much as possible, I've tried to preserve the user's column choices.  With further testing and
    live work, it was found that column choices from one file, could, in some circumstances, adversely
    affect a following file having a different format.  This in two cases led to KMM crashing or stack
    corruption, through indexes going out of range.  It was necessary to drop the preservation of memo
    column settings between files, as the memo field is optional and not guaranteed to be wanted for 
    the following file.  Also, better range checking of column choices.
  Improved detection of conflicting columns during repeated changing of selections.
  A couple of translation issues addressed.
Improvement:
  Allow dates with no separators to be handled.
  Tidy up (with white space changes, I'm afraid.  


Diffs
-----

  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlgdecl.ui 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.h 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvprocessing.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.h 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvutil.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlgdecl.ui 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.h 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investprocessing.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp 1210268 
  /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlgdecl.ui 1210268 

Diff: http://svn.reviewboard.kde.org/r/6238/diff


Testing
-------

Intensive stress testing of UI column choices.  Many different format files used. Unit test improved.


Thanks,

Allan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101230/ea27adab/attachment.htm