[Kmymoney-devel] Re: Review Request: Balance cache object for use by MyMoneyFile

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5404/#review9417
-----------------------------------------------------------



/trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt
<http://svn.reviewboard.kde.org/r/5404/#comment10423>

    Do we really need to export the balance cache details to the public? The files in mymoney_HEADERS get installed so that it can be included by applications. From my POV the cache should be hidden inside MyMoneyFile.



/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.h
<http://svn.reviewboard.kde.org/r/5404/#comment10426>

    Why don't you use @note here? See http://www.stack.nl/~dimitri/doxygen/commands.html#cmdnote



/trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp
<http://svn.reviewboard.kde.org/r/5404/#comment10425>

    Once we have a balance cache in the MyMoneyFile object we don't need a second cache in the storage layer. Can't we just get rid of this here?


- Thomas


On 2010-12-26 02:00:50, Fernando Vilas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5404/
> -----------------------------------------------------------
> 
> (Updated 2010-12-26 02:00:50)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Initial cut at the balance cache for the MyMoneyFile layer. Nothing uses it other than the test driver yet, but that will change once this is committed. Does it have a reasonable interface? Does it need something else added, like a model interface?
> 
> This interface is subject to change for now, but should be stable enough to start the next phase if it does not need revision first.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/CMakeLists.txt 1209232 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecache.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecachetest.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneybalancecachetest.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfile.h 1209232 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyfile.cpp 1209232 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgr.h 1209232 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp 1209232 
> 
> Diff: http://svn.reviewboard.kde.org/r/5404/diff
> 
> 
> Testing
> -------
> 
> Built test driver, and the object passes all tests. Hooray, test-driven-development
> 
> 
> Thanks,
> 
> Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20101226/0dfd509f/attachment.htm