[Kmymoney-devel] Review Request: CSVImporter Plugin for KMyMoney

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5162/#review7280
-----------------------------------------------------------


I added a few remarks. As you will see, some of them are general, and you will have to check similar cases within the patch.
Also, before a final approval I would like to have Cristian review this. That might take a while, but I promise to keep you busy in the meantime.


/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h
<http://reviewboard.kde.org/r/5162/#comment7373>

    we usually subclass the ui class, to work on it directly. Since you have to define it anyway, you save a lot of work.



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h
<http://reviewboard.kde.org/r/5162/#comment7372>

    If this can't be calculated dynamically, then a comment should be added that this number has to be increased when adding a new type of column



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h
<http://reviewboard.kde.org/r/5162/#comment7374>

    if you subclass it, you don't need this one



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h
<http://reviewboard.kde.org/r/5162/#comment7378>

    unless there is a good reason, this class is complex enough to live in its own file.
    
    Also, IO suggest that it outputs data to csv. Isn't this import only?



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp
<http://reviewboard.kde.org/r/5162/#comment7375>

    These messages need some clarification.
    Perhaps something like "The column or the credit field is already selected!"



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp
<http://reviewboard.kde.org/r/5162/#comment7376>

    "Please select a different column or field"



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp
<http://reviewboard.kde.org/r/5162/#comment7377>

    remove qDebug statements



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui
<http://reviewboard.kde.org/r/5162/#comment7369>

    All these layouts should not have fixed values



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui
<http://reviewboard.kde.org/r/5162/#comment7370>

    These should have a comment to explain the translators what these items are supposed to be.



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui
<http://reviewboard.kde.org/r/5162/#comment7371>

    When possible, use KDE classes for the UI. In this case, use KPushButton



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterrc
<http://reviewboard.kde.org/r/5162/#comment7379>

    make it relative to home directory



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h
<http://reviewboard.kde.org/r/5162/#comment7381>

    same as above, it would be better to subclass the ui



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h
<http://reviewboard.kde.org/r/5162/#comment7382>

    Same as above



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.ui
<http://reviewboard.kde.org/r/5162/#comment7380>

    same comment as previous .ui



/trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp
<http://reviewboard.kde.org/r/5162/#comment7383>

    remove qDebug statements


- Alvaro


On 2010-08-26 21:40:39, Allan Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5162/
> -----------------------------------------------------------
> 
> (Updated 2010-08-26 21:40:39)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> This is the revised version of the kmymoney csvimporter, which was originally submitted for me by Cristian.  I was unable to find a way to update that, possibly because I was not the original submitter.
> 
> Apart from addressing the original criticisms, I've added further improvements and spent quite a bit of time tightening its error checking.
> 
> As well as the needed files, I've included csvimporterrc.  This is not *needed* by the importer, as it will create one.  However, as the user may wish to supplement the common basic transaction types , in order to cope with his own bank file layout idiosyncrasies, it may serve as an illustration or example.  Where it should reside, I don't know.  I would also wish to include some basic instructions, but in what form, and where?
> 
> Apart from functioning as a plugin, it also can produce QIF files if required.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/CMakeLists.txt 1168455 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/CMakeLists.txt PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/convdate.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvdatetest.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterdlg.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterplugin.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/csvimporterrc PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/investmentdlg.ui PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.desktop PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/kmm_csvimport.rc PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.h PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlg.cpp PRE-CREATION 
>   /trunk/extragear/office/kmymoney/kmymoney/plugins/csvimport/redefinedlgdecl.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/5162/diff
> 
> 
> Testing
> -------
> 
> I've run Krazy2 and astyle against it, also unit test.  
> 
> Operationally, I've imported CSV files of checking/savings accounts from a number of UK and other banks.  Also, investment account CSV files from a UK and a US investment institution.
> 
> 
> Thanks,
> 
> Allan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100829/a08b86ef/attachment-0001.html