[Kmymoney-devel] Review Request: new payee fields: bank code number and account number

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5189/#review7278
-----------------------------------------------------------


It looks ok from the formal side, but you should give the variables a more descriptive name. The full length name is not that long and it is worth the effort to avoid confusions later on.


/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayee.h
<http://reviewboard.kde.org/r/5189/#comment7367>

    Please make the variable name more descriptive



/trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayee.h
<http://reviewboard.kde.org/r/5189/#comment7368>

    Here applies the same as above


- Alvaro


On 2010-08-29 20:01:33, Sebastian Held wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5189/
> -----------------------------------------------------------
> 
> (Updated 2010-08-29 20:01:33)
> 
> 
> Review request for kmymoney.
> 
> 
> Summary
> -------
> 
> Please refer to BUG 249403 (new payee fields: bank code number and account number)
> This patch includes the database changes. I'm not sure, if I got the db stuff right.
> 
> This review board didn't accept my git diffs... Thus the diff is created by post-review; I hope it's complete.
> 
> 
> This addresses bug 249403.
>     https://bugs.kde.org/show_bug.cgi?id=249403
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayee.h 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneypayee.cpp 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneydbdef.cpp 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.h 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/storage/mymoneystoragesql.cpp 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kpayeesview.cpp 1169309 
>   /trunk/extragear/office/kmymoney/kmymoney/views/kpayeesviewdecl.ui 1169309 
> 
> Diff: http://reviewboard.kde.org/r/5189/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100829/2e8e9984/attachment-0001.htm