[Kmymoney-devel] Review Request: Remove MyMoneySchedule::stringToOccurrence() method

[Fernando Vilas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5121/#review7217
-----------------------------------------------------------

Ship it!


KMyMoneyFrequencyCombo::data should be a private member. Other than that, it looks good to go. Nice work.

- Fernando


On 2010-08-25 10:48:57, Alvaro Soliverez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5121/
> -----------------------------------------------------------
> 
> (Updated 2010-08-25 10:48:57)
> 
> 
> Review request for kmymoney and Fernando Vilas.
> 
> 
> Summary
> -------
> 
> Remove the MyMoneySchedule::stringToOccurrence() method, as it has translation problems.
> The big issue lies in the newloanwizard, in which the payment frecuency field is not set correctly.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduled.h 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduled.cpp 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduletest.h 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/mymoney/mymoneyscheduletest.cpp 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneymvccombo.h 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneymvccombo.cpp 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/durationwizardpage.cpp 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/keditloanwizard.cpp 1166488 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/knewloanwizard.cpp 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.h 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpage.cpp 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/paymentfrequencywizardpagedecl.ui 1166480 
>   /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/summarywizardpage.cpp 1166480 
> 
> Diff: http://reviewboard.kde.org/r/5121/diff
> 
> 
> Testing
> -------
> 
> Tested with a liability loan, modifying interest, fees and other info.
> 
> 
> Thanks,
> 
> Alvaro
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100826/66a23dfb/attachment.html