[Kmymoney-devel] Review Request: Add a cache to isProcessingDay to speed up holiday queries

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5033/
-----------------------------------------------------------

(Updated 2010-08-15 12:11:09.078830)


Review request for kmymoney.


Changes
-------

I've included Thomas' comments, plus:
- clear and load the cache only if the region has changed
- load the holidays for 2 years or the forecast timeframe, whichever is longer


Summary
-------

This is a quick and dirty fix to cache the calls to HolidayRegion. The best solution would be to call the holiday list and load that preemptively for a given period of time.


This addresses bug 247912.
    https://bugs.kde.org/show_bug.cgi?id=247912


Diffs (updated)
-----

  /trunk/extragear/office/kmymoney/kmymoney/kmymoney.h 1163570 
  /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1163570 

Diff: http://reviewboard.kde.org/r/5033/diff


Testing
-------

Tested it with region set to none and region set to Argentina.


Thanks,

Alvaro

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100815/810ef3be/attachment.htm