[Kmymoney-devel] Review Request: Add a cache to isProcessingDay to speed up holiday queries

[Alvaro Soliverez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5033/
-----------------------------------------------------------

(Updated 2010-08-15 03:53:10.387698)


Review request for kmymoney.


Changes
-------

I added a preload method with the call suggested by John Layt, to get all holidays for the forecast timeframe, which is the timeframe most commonly used within KMyMoney.
A possible improvement on this patch would be adding a call in reports when schedules are included, to prefetch the holidays for the report timeframe.


Summary
-------

This is a quick and dirty fix to cache the calls to HolidayRegion. The best solution would be to call the holiday list and load that preemptively for a given period of time.


This addresses bug 247912.
    https://bugs.kde.org/show_bug.cgi?id=247912


Diffs (updated)
-----

  /trunk/extragear/office/kmymoney/kmymoney/kmymoney.h 1163570 
  /trunk/extragear/office/kmymoney/kmymoney/kmymoney.cpp 1163570 

Diff: http://reviewboard.kde.org/r/5033/diff


Testing
-------

Tested it with region set to none and region set to Argentina.


Thanks,

Alvaro

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20100815/141fb589/attachment.htm