[Kmymoney-devel] Latest SVN - OFX Import Crash

[Greg Darke]

Hi all

I managed to confirm this problem by creating a new file containing 
multiple consecutive accounts to be downloaded from the same 
institution.  In my case however, there is no crash, just the second 
account at the same institution is not updated, although the data is 
downloaded.

The current logic assumes the following sequence of callbacks for each 
account

slotOfxConnected()
slotOfxData() 1 or more
slotOfxFinished()

According to the debug output, the problem is that slotOfxConnected() is 
NOT called on the second and subsequent account -- it is only called 
again when the download URL changes.

Luckily there is copious debug statements in KOfxDirectConnectDlg

Processing of the first account results in the following:

kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setStatus: 
STATUS:  "Contacting 
https://ofx.bankofamerica.com/cgi-forte/fortecgi?servicename=ofx_2-3&pagename=ofx..."
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setStatus: 
STATUS:  "Connection established, retrieving data..."
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setDetails: 
DETAILS:  "Downloading data to 
/home/skunk/.kde4/tmp-skunk-develop/kmymoneyp18751.tmp..."
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setDetails: 
DETAILS:  "Got 49 bytes"
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setDetails: 
DETAILS:  "Got 954 bytes"
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setDetails: 
DETAILS:  "Got 0 bytes"
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setStatus: 
STATUS:  "Completed."
OfxImporterPlugin::storeStatements() with 1 statements called

The second and subsequent account AT THE SAME institution results in the 
following debug output:

kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setStatus: 
STATUS:  "Contacting 
https://ofx.bankofamerica.com/cgi-forte/fortecgi?servicename=ofx_2-3&pagename=ofx..."
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::slotOfxData: 
void ofxdcon::slotOfxData():: Not currently connected!
QTextStream: No device
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setDetails: 
DETAILS:  "Got 49 bytes"
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::slotOfxData: 
void ofxdcon::slotOfxData():: Not currently connected!
QTextStream: No device
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setDetails: 
DETAILS:  "Got 961 bytes"
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::slotOfxData: 
void ofxdcon::slotOfxData():: Not currently connected!
QTextStream: No device
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setDetails: 
DETAILS:  "Got 0 bytes"
kmymoney(18751)/kdecore (KLibrary) KOfxDirectConnectDlg::setStatus: 
STATUS:  "Completed."

To me it appears as if there is some optimization going on in KIO 
somewhere where the HTTP connection is being reused if the new job is 
connecting to the same URL?

Regards
Greg

------------------------------

Message: 3
Date: Tue, 3 Aug 2010 23:55:16 -0300
From: Alvaro Soliverez <asoliverez at kde.org>
Subject: Re: [Kmymoney-devel] Latest SVN - OFX Import Crash
To: KMyMoney KDE Development List <kmymoney-devel at kde.org>
Message-ID:
	<AANLkTi=9ZWeiJ5Gq+m0wA_v0Wsy2i79R7QPcB+wQmAS=@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1

Thomas or someone else might answer these questions better, as I don't
know a bit about how the OFX works.

Regards,
Alvaro

On Tue, Aug 3, 2010 at 11:51 PM, Brendan Coupe <brendan at coupeware.com> 
wrote:
> The accounts work individually but I have 12 or so accounts that I download
> and downloading each separately is not a great workaround. I use the old
> version for OFX downloads and therefore I'm not doing much testing with KMM
> 4.
> Is something being done during this process when the next account being
> downloaded is at the same bank as the last download that might?explain?this?
> Where is the code for single account downloads and all accounts? I'm not a
> C++ programmer but I can poke around and see if I find anything suspicious.
> Did anything change in this part of the code in KMM 1.0.5 versus 3.98.x? On
> the same computer do the two programs use the same version of ofx or could
> the ofx libraries be the problem?
>
> ----
> Brendan
>
>
> On Tue, Aug 3, 2010 at 6:03 PM, Alvaro Soliverez <asoliverez at kde.org> wrote:
>>
>> Is there a workaround for this? Can you check one by one and it works ok?
>>
>> If it doesn't crash anymore, it's probably because of a bug I fixed
>> regarding an invalid temp file. That won't help us find the true
>> source of the problem, and I don't have an OFX account here to check.
>>
>> Regards,
>> Alvaro
>>
>> On Mon, Aug 2, 2010 at 6:47 PM, Brendan Coupe <brendan at coupeware.com>
>> wrote:
>> > It's not crashing on me any more, it's just skipping the second account
>> > at
>> > the banks with more than one account so I don't think I can get you a
>> > backtrace. If I can tell me how.
>> > ----
>> > Brendan
>> >
>> >
>> > On Mon, Aug 2, 2010 at 9:54 AM, Thomas Baumgart <thb at net-bembel.de>
>> > wrote:
>> >>
>> >> Hi,
>> >>
>> >> on Monday 02 August 2010 Brendan Coupe wrote:
>> >>
>> >>
>> >>
>> >> > Is there any sensitive information in the backtrace? I don't want to
>> >> > find a
>> >> > bunch of big withdrawals then next time I check my accounts:)
>> >>
>> >> Feel free to send it to our personal e-mail addresses if unsure. Also
>> >> use
>> >> GPG
>> >> if possible. That should give you the security that not everyone
>> >> reading
>> >> the
>> >> mail can grab in your pocket ehhmm account.
>> >>
>> >> --
>> >>
>> >> Regards
>> >>
>> >> Thomas Baumgart
>> >>
>> >> GPG-FP: E55E D592 F45F 116B 8429 ? 4F99 9C59 DB40 B75D D3BA
>> >> -------------------------------------------------------------
>> >> Memory's the second thing to go ... Can't remember the first.
>> >> -------------------------------------------------------------
>> >
>> >
>
>