[Kmymoney-devel] qt designer plugin patch

[Cristian Oneţ]

În data de Duminică 25 Octombrie 2009 11:56:27 Thomas Baumgart a scris:
> Hi,
> 
> on Monday 19 October 2009 Cristian Oneţ wrote:
> > Hi,
> >
> > I've attached a patch for the build system that makes the designer plugin
> > functional again. The change in kmymoney2/CMakeLists.txt is just a minor
> > cleanup. The real fix is in kmymoney2/widgets/CMakeLists.txt. I don't
> > know that much about the build system that's why I've submitted the patch
> > for review (to avoid any errors like the ones I've made so far). Could
> > you please take a look at it, I've tried to restore things the 'way they
> > were when they worked'. This also fix the needles installation of
> >  libkmymoney.so.
> 
> My system currently is in a somewhat unknown state if it comes to the KDE4
> development. I don't see a difference with or without the patch. The
>  widgets do not show up in Qt designer either way (yes, I have the resp.
>  switch turned on)
> 
> So I cannot really judge if the patch is good or not. I don't see a
>  difference here on my SuSE system.
> 
> The only thing I noticed is, that if I use a fresh build environment, run
>  make once and run it a second time, a lot of stuff is re-build during the
>  second run but not during a third. This seems to be unrelated to the patch
>  though.
> 
So if I say that I've tested the patch on two systems: my real machine 
(Gentoo) and a KUbuntu VM and it works as expected in both cases would it be 
OK to commit it to SVN?

-- 
Regards,

Cristian Oneţ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20091025/a2a6e495/attachment.sig