[Kmymoney-devel] .xml save not working

[Alvaro Soliverez]

On Thu, Oct 15, 2009 at 3:24 AM, Thomas Baumgart <thb at net-bembel.de> wrote:

> On Thursday 15 October 2009 04:46:53 Alvaro Soliverez wrote:
> > > > I commited to SVN a fix for saving XML files. It's not what I would
> > > > have liked to do but because of the state of the saveFile and
> > > > saveToLocalFile functions this was the best compromise from my point
> of
> > > > view. When I say 'the state' of these functions I mean that the code
> is
> > > > not quite
> > >
> > > straight
> > >
> > > >  forward to read.
> > >
> > > I added another fix which also make it possible to save a remote file.
> I
> > > moved
> > > all calls to open() into the saveToLocalFile(). I labeled the commit
> "Fix
> > > a combo in the icalendar plugin settings page." by mistake, sorry for
> > > that. I'll
> > > try to be more careful in the future.
> >
> > I've been thinking about this. Shouldn't all these methods be moved to
> the
> > engine?
> > That way, we could unit test them.
>
> Don't know. They are depending on the UI. And I still try to keep the
> engine
> free of UI code.
>
>
I agree, the parts depending on UI code should stay on the views, but I
think there is a big chunk of these methods (saveToLocalFile,
saveToDatabase, etc) that might be best placed in the engine.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kmymoney-devel/attachments/20091015/ac61917b/attachment.htm