[Kmymoney-devel] PivotTableTest::testAdvancedFilter fails
Cristian Oneţ
onet.cristian at gmail.com
Sun Nov 22 18:19:36 CET 2009
În data de Duminică 22 Noiembrie 2009 14:19:06 Alvaro Soliverez a scris:
> Can you quickly explain the fix? I looked at it but I don't quite get it.
>
Yep, it's pretty simple. I wanted to add size checks before using operator[]
on the QList to avoid a crash. The thing is that I've got the size check wrong
the first time. So for example when using operator[](0) the list's size must be
greater than 0 (not smaller than 1 as it was done when I introduced the bug).
In the same way when using operator[](1) the list's size must be greater than
1.
> On Sun, Nov 22, 2009 at 8:42 AM, Cristian Oneţ <onet.cristian at gmail.com>
wrote:
> > În data de Duminică 22 Noiembrie 2009 01:40:17 Alvaro Soliverez a scris:
> >> Any idea when was the last time this test was working ok?
> >> So we can have a timeframe to look for changes that affect this.
> >
> > I messed things up, sorry. It is fixed now in SVN.
>
> _______________________________________________
> KMyMoney-devel mailing list
> KMyMoney-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kmymoney-devel
>
--
Regards,
Cristian Oneţ
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kmymoney-devel/attachments/20091122/c1027d9c/attachment.sig
More information about the KMyMoney-devel
mailing list