[kmobiletools] KDE/kdepim/kmobiletools/tests/testlibkmobiletools

[David Faure]

On Thursday 21 June 2007, Allen Winter wrote:
> On Thursday 21 June 2007 10:22:21 am Marco Gulino wrote:
> > SVN commit 678491 by gulino:
> > 
> > SILENT: Got the right one this time..
> > 
> > 
> >  M  +1 -2      CMakeLists.txt  
> > 
> > 
> > --- trunk/KDE/kdepim/kmobiletools/tests/testlibkmobiletools/CMakeLists.txt #678490:678491
> > @@ -1,11 +1,10 @@
> >  include_directories(
> >     ${CMAKE_CURRENT_SOURCE_DIR}
> > -   ${CMAKE_CURRENT_SOURCE_DIR}/../../kmobiletools/libkmobiletools
> > +   ${CMAKE_CURRENT_SOURCE_DIR}/../../kmobiletools
> 
> ^ick.
> how about  ${CMAKE_SOURCE_DIR}/kmobiletools
> ?

Using relative paths (with CMAKE_CURRENT_SOURCE_DIR) allows 
1) to move the whole thing without having to adjust all CMakeLists.txt files
 (e.g. if kdepim/kmobiletools became kdepim/tools/kmobiletools, like we did in kdebase)
2) to configure only one subdir with cmake instead of the whole module, possibly
 (like I do in extragear and playground).

So in general I do recommend to use relative paths instead of absolute paths.

-- 
David Faure, faure at kde.org, dfaure at klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions