[kmobiletools] KDE/kdepim/kmobiletools/kmobiletools

[Matthias Lechner]

SVN commit 673300 by lechner:

more API cleaning (removing diffSMSList())
RockMan: the change should be ok, but please review this though (especially the AT engine change)


 M  +3 -7      engines/at_engine/at_engine.cpp  
 M  +0 -12     libkmobiletools/engine.cpp  
 M  +0 -2      libkmobiletools/engine.h  


--- trunk/KDE/kdepim/kmobiletools/kmobiletools/engines/at_engine/at_engine.cpp #673299:673300
@@ -168,15 +168,12 @@
             emit phoneBookChanged();
             break;
         case KMobileTools::Job::fetchSMS:
-            diffSMSList()->append(  ((FetchSMS*) job)->smsList );
             if( ((FetchSMS*) job)->last()) {
-                engineData()->smsList()->sync(diffSMSList() );
+                engineData()->smsList()->sync( ((FetchSMS*)job)->smsList );
                 queue_sms=false;
-//                  p_smsList->dump();
-//                  p_diffSMSList->dump();
             }
-//         emit smsListUpdated();
-        break;
+//          emit smsListUpdated();
+            break;
         case KMobileTools::Job::testPhoneFeatures:
             wconfig->setFstype( ((TestPhoneFeatures *) job)->getAbilities().filesystem() );
         wconfig->writeConfig();
@@ -297,7 +294,6 @@
 {
     if(statusJobsSuspended() || ! device ) return;
 //     p_smsList->clear();
-    diffSMSList()->clear();
     if(queue_sms) return;
     QStringList sl_slots=config()->at_smsslots();
     if( ! sl_slots.count() ) {
--- trunk/KDE/kdepim/kmobiletools/kmobiletools/libkmobiletools/engine.cpp #673299:673300
@@ -27,8 +27,6 @@
 #include "weaver.h"
 #include "enginedata.h"
 
-#include "smslist.h"
-
 using namespace KMobileTools;
 
 class KMobileTools::EnginePrivate {
@@ -36,7 +34,6 @@
     EnginePrivate() : p_pluginInfo(NULL), enginedata(NULL)
     {}
         KPluginInfo *p_pluginInfo;
-        SMSList *p_diffSMSList;
         KMobileTools::Weaver *weaver;
 
         QList<KMobileTools::Job*> jobs;
@@ -74,7 +71,6 @@
 //     b_ownweaver=ownWeaver;
     /*if(ownWeaver) */d->weaver=new KMobileTools::Weaver(this/*, name, 2, 2*/);
 //     else weaver=ThreadWeaver::Weaver::instance();
-    d->p_diffSMSList=new SMSList();
     connect(d->weaver, SIGNAL(jobDone(KMobileTools::Job*) ), SLOT(processSlot(KMobileTools::Job*) ) );
     connect(d->weaver, SIGNAL(suspended() ), this, SLOT(slotWeaverSuspended() ) );
 
@@ -102,7 +98,6 @@
 //     weaver=NULL;
 
 //     delete p_addresseeList;
-    delete d->p_diffSMSList;
 
     EnginesList::instance()->remove( this );
     delete d;
@@ -120,13 +115,6 @@
     return d->weaver;
 }
 
-
-
-SMSList *Engine::diffSMSList() const
-{
-    return d->p_diffSMSList;
-}
-
 QStringList Engine::smsFolders()
 {
     return d->s_folders;
--- trunk/KDE/kdepim/kmobiletools/kmobiletools/libkmobiletools/engine.h #673299:673300
@@ -111,8 +111,6 @@
          */
         KMobileTools::Weaver *ThreadWeaver();
 
-        SMSList* diffSMSList() const; /// @TODO remove?
-
         /**
          * Retrieves the phone SMS folders.
          *