New Defects reported by Coverity Scan for krita

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to krita found with Coverity Scan.

3 new defect(s) introduced to krita found with Coverity Scan.
54 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 442784:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/tymon/kritadev/krita/libs/resources/KoResourceLoadResult.cpp: 56 in KoResourceLoadResult::embeddedResource() const()


________________________________________________________________________________________________________
*** CID 442784:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/tymon/kritadev/krita/libs/resources/KoResourceLoadResult.cpp: 56 in KoResourceLoadResult::embeddedResource() const()
50     
51     KoResourceSP KoResourceLoadResult::resource() const noexcept
52     {
53         return m_d->value.which() == 0 ? boost::get<KoResourceSP>(m_d->value) : KoResourceSP();
54     }
55     
>>>     CID 442784:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "boost::wrapexcept<boost::bad_get>" is thrown but the exception specification "noexcept" doesn't allow it to be thrown. This will result in a call to terminate().
56     KoEmbeddedResource KoResourceLoadResult::embeddedResource() const noexcept
57     {
58         return m_d->value.which() == 1 ? boost::get<KoEmbeddedResource>(m_d->value) : KoEmbeddedResource();
59     }
60     
61     KoResourceSignature KoResourceLoadResult::signature() const

** CID 442783:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/tymon/kritadev/krita/libs/resources/KoResourceLoadResult.cpp: 51 in KoResourceLoadResult::resource() const()


________________________________________________________________________________________________________
*** CID 442783:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/tymon/kritadev/krita/libs/resources/KoResourceLoadResult.cpp: 51 in KoResourceLoadResult::resource() const()
45     }
46     
47     KoResourceLoadResult::~KoResourceLoadResult()
48     {
49     }
50     
>>>     CID 442783:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "boost::wrapexcept<boost::bad_get>" is thrown but the exception specification "noexcept" doesn't allow it to be thrown. This will result in a call to terminate().
51     KoResourceSP KoResourceLoadResult::resource() const noexcept
52     {
53         return m_d->value.which() == 0 ? boost::get<KoResourceSP>(m_d->value) : KoResourceSP();
54     }
55     
56     KoEmbeddedResource KoResourceLoadResult::embeddedResource() const noexcept

** CID 442782:  API usage errors  (INVALIDATE_ITERATOR)
/home/tymon/kritadev/krita/libs/ui/opengl/KisOpenGLBufferCircularStorage.cpp: 98 in KisOpenGLBufferCircularStorage::allocateMoreBuffers()()


________________________________________________________________________________________________________
*** CID 442782:  API usage errors  (INVALIDATE_ITERATOR)
/home/tymon/kritadev/krita/libs/ui/opengl/KisOpenGLBufferCircularStorage.cpp: 98 in KisOpenGLBufferCircularStorage::allocateMoreBuffers()()
92         const size_t numBuffers = nextPowerOfTwo(m_d->buffers.size());
93     
94         KIS_SAFE_ASSERT_RECOVER_RETURN(!m_d->buffers.empty());
95     
96         QOpenGLBuffer *const begin = &(*m_d->buffers.begin());
97         QOpenGLBuffer *const middle = begin + m_d->nextBuffer;
>>>     CID 442782:  API usage errors  (INVALIDATE_ITERATOR)
>>>     Dereferencing iterator "this->m_d->buffers.end()" though it is already past the end of its container.
98         QOpenGLBuffer *const end = &(*m_d->buffers.end());
99     
100         std::rotate(begin, middle, end);
101     
102         m_d->nextBuffer = m_d->buffers.size();
103     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoiVvSSc0Ywjss83d7yOEUgcCB0VGS755ZaA-2FhoVtwbuw-3D-3DfFVr_9IaX5f-2FHpKL9E6YDsrt7GXrayr4Tk6CKCUhJvkNHrt4n-2FK-2FOHyu7jAaJ5069tupx8BCh-2B3geMu266IZXeY-2B45dmp2Nmhznkrv3TwVjigCX7GUtWMtBW0xvdHf28S9A0M407lAuBWoXCnPq7WPIIFwEn-2FiQKRJzgB0gxcGbskV46QEuGbf5WMtp-2FkFuSpOeNWSFp0igueg-2Bw7G96yXWk7SA-3D-3D