New Defects reported by Coverity Scan for krita
scan-admin at coverity.com
scan-admin at coverity.com
Thu Feb 25 07:26:49 GMT 2021
Hi,
Please find the latest report on new defect(s) introduced to krita found with Coverity Scan.
105 new defect(s) introduced to krita found with Coverity Scan.
118 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 105 defect(s)
** CID 311014: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/png/tests/kis_png_test.cpp: 178 in main()
________________________________________________________________________________________________________
*** CID 311014: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/png/tests/kis_png_test.cpp: 178 in main()
172 KoColorSpaceRegistry::instance()->colorSpace(
173 RGBAColorModelID.id(),
174 Integer8BitsColorDepthID.id(),
175 KoColorSpaceRegistry::instance()->p2020PQProfile()));
176 }
177
>>> CID 311014: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311013: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/jp2/tests/KisJP2Test.cpp: 54 in main()
________________________________________________________________________________________________________
*** CID 311013: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/jp2/tests/KisJP2Test.cpp: 54 in main()
48 {
49 TestUtil::testImportIncorrectFormat(QString(FILES_DATA_DIR), JP2Mimetype);
50 }
51
52
53
>>> CID 311013: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311012: Null pointer dereferences (FORWARD_NULL)
/home/boud/dev/krita/libs/image/kis_regenerate_frame_stroke_strategy.cpp: 158 in KisRegenerateFrameStrokeStrategy::doStrokeCallback(KisStrokeJobData *)()
________________________________________________________________________________________________________
*** CID 311012: Null pointer dereferences (FORWARD_NULL)
/home/boud/dev/krita/libs/image/kis_regenerate_frame_stroke_strategy.cpp: 158 in KisRegenerateFrameStrokeStrategy::doStrokeCallback(KisStrokeJobData *)()
152 {
153 Private::Data *d = dynamic_cast<Private::Data*>(data);
154 KIS_ASSERT(d);
155 KIS_ASSERT(!m_d->dirtyRegion.isEmpty());
156 KIS_ASSERT(m_d->type == EXTERNAL_FRAME);
157
>>> CID 311012: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "d".
158 KisBaseRectsWalkerSP walker = new KisFullRefreshWalker(d->cropRect);
159 walker->collectRects(d->root, d->rect);
160
161 KisAsyncMerger merger;
162 merger.startMerge(*walker);
163 }
** CID 311011: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/svg/tests/kis_svg_test.cpp: 57 in main()
________________________________________________________________________________________________________
*** CID 311011: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/svg/tests/kis_svg_test.cpp: 57 in main()
51 void KisSvgTest::testImportIncorrectFormat()
52 {
53 TestUtil::testImportIncorrectFormat(QString(FILES_DATA_DIR), SvgMimetype);
54 }
55
56
>>> CID 311011: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311010: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/tiff/tests/kis_tiff_test.cpp: 201 in main()
________________________________________________________________________________________________________
*** CID 311010: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/tiff/tests/kis_tiff_test.cpp: 201 in main()
195 {
196 TestUtil::testImportIncorrectFormat(QString(FILES_DATA_DIR), TiffMimetype);
197 }
198
199
200
>>> CID 311010: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311009: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_node_model_test.cpp: 117 in main()
________________________________________________________________________________________________________
*** CID 311009: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_node_model_test.cpp: 117 in main()
111 m_nodeModel->setDummiesFacade(m_shapeController, m_image, 0, 0, 0);
112 new ModelTest(m_nodeModel, this);
113
114 m_image->flatten(0);
115 }
116
>>> CID 311009: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311008: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_doc2_test.cpp: 61 in main()
________________________________________________________________________________________________________
*** CID 311008: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_doc2_test.cpp: 61 in main()
55
56 doc->loadNativeFormat(fname);
57 doc->loadNativeFormat(fname2);
58 }
59
60
>>> CID 311008: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311007: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/image/tests/kis_pixel_selection_test.cpp: 594 in main()
________________________________________________________________________________________________________
*** CID 311007: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/image/tests/kis_pixel_selection_test.cpp: 594 in main()
588 QPoint(15,5),
589 QPoint(20,5),
590 QPoint(20,0),
591 QPoint(0,0)})}));
592 }
593
>>> CID 311007: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311006: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/ora/tests/KisOraTest.cpp: 55 in main()
________________________________________________________________________________________________________
*** CID 311006: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/impex/ora/tests/KisOraTest.cpp: 55 in main()
49 {
50 TestUtil::testImportIncorrectFormat(QString(FILES_DATA_DIR), OraMimetype);
51 }
52
53
54
>>> CID 311006: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311005: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/color/lcms2engine/tests/TestColorSpaceRegistry.cpp: 91 in main()
________________________________________________________________________________________________________
*** CID 311005: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/color/lcms2engine/tests/TestColorSpaceRegistry.cpp: 91 in main()
85 cmsWriteTag(lcmsProfile, cmsSigProfileDescriptionTag, testProfileName.toLatin1().constData());
86 cmsWriteTag(lcmsProfile, cmsSigDeviceModelDescTag, testProfileName.toLatin1().constData());
87 cmsWriteTag(lcmsProfile, cmsSigDeviceMfgDescTag, "");
88
89 }
90
>>> CID 311005: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311004: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_painting_assistants_decoration_test.cpp: 216 in main()
________________________________________________________________________________________________________
*** CID 311004: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_painting_assistants_decoration_test.cpp: 216 in main()
210 QVERIFY(adjustedPosition.y() == 50.0);
211 paintingAssistantsDecoration->endStroke();
212
213 }
214
215
>>> CID 311004: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311003: Control flow issues (DEADCODE)
/home/boud/dev/krita/libs/global/kis_assert.cpp: 102 in kis_assert_common(const char *, const char *, int, bool, bool)()
________________________________________________________________________________________________________
*** CID 311003: Control flow issues (DEADCODE)
/home/boud/dev/krita/libs/global/kis_assert.cpp: 102 in kis_assert_common(const char *, const char *, int, bool, bool)()
96 QMessageBox::Ignore | QMessageBox::Abort,
97 QMessageBox::Ignore);
98 }
99
100 if (button == QMessageBox::Abort) {
101 qFatal("%s", shortMessage.toLatin1().data());
>>> CID 311003: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "if (isIgnorable) {
QMessa...".
102 } else if (isIgnorable) {
103 // Assert is a bug! Please don't change this line to warnKrita,
104 // the user must see it!
105 qWarning("%s", shortMessage.toLatin1().data());
106 } else if (throwException) {
107 throw KisAssertException(shortMessage.toLatin1().data());
** CID 311002: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/flake/tests/TestKoShapeRegistry.cpp: 197 in main()
________________________________________________________________________________________________________
*** CID 311002: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/flake/tests/TestKoShapeRegistry.cpp: 197 in main()
191 KoShape *shape = registry->createShapeFromXML(frameElement, shapeContext);
192
193 QVERIFY(shape);
194 QCOMPARE(shape->absoluteOutlineRect(), QRectF(83, 41, 226,141));
195 }
196
>>> CID 311002: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311001: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/KisDocumentReplaceTest.cpp: 65 in main()
________________________________________________________________________________________________________
*** CID 311001: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/KisDocumentReplaceTest.cpp: 65 in main()
59 QCOMPARE(oldNodes.size(), newNodes.size());
60
61 KisPart::instance()->removeDocument(anotherDoc);
62 finalize();
63 }
64
>>> CID 311001: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 311000: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_exiv2_test.cpp: 109 in main()
________________________________________________________________________________________________________
*** CID 311000: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_exiv2_test.cpp: 109 in main()
103 QCOMPARE(store->getEntry(xmpSchema, "ModifyDate").value(), Value(QDateTime(QDate(2007, 5, 8), QTime(0, 19, 18))));
104
105 const KisMetaData::Schema* mknSchema = KisMetaData::SchemaRegistry::instance()->schemaFromUri(KisMetaData::Schema::MakerNoteSchemaUri);
106 QCOMPARE(store->getEntry(mknSchema, "RawData").value(), Value("SFBNZXQ="));
107 }
108
>>> CID 311000: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 310999: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/libkis/tests/TestNotifier.cpp: 52 in main()
________________________________________________________________________________________________________
*** CID 310999: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/libkis/tests/TestNotifier.cpp: 52 in main()
46
47 void TestNotifier::documentAdded(Document *image)
48 {
49 m_document = image;
50 }
51
>>> CID 310999: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 310998: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_derived_resources_test.cpp: 116 in main()
________________________________________________________________________________________________________
*** CID 310998: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_derived_resources_test.cpp: 116 in main()
110 QCOMPARE(spy.size(), 1);
111 QCOMPARE(spy[0][0].toInt(), (int)KoCanvasResource::Opacity);
112 QCOMPARE(spy[0][1].toDouble(), 0.8);
113 spy.clear();
114 }
115
>>> CID 310998: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 310997: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_shape_commands_test.cpp: 621 in main()
________________________________________________________________________________________________________
*** CID 310997: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_shape_commands_test.cpp: 621 in main()
615 KoFlake::scaleShapeGlobal(w.path, 1.0, 2.0, QPointF(-20,110));
616 QCOMPARE(w.path->outlineRect(), QRectF(10, 10, 100, 0));
617 QCOMPARE(w.path->absoluteOutlineRect(), QRectF(-10, -90, 0, 200));
618 }
619 }
620
>>> CID 310997: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 310996: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/paintops/libpaintop/tests/kis_embedded_pattern_manager_test.cpp: 210 in main()
________________________________________________________________________________________________________
*** CID 310996: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/plugins/paintops/libpaintop/tests/kis_embedded_pattern_manager_test.cpp: 210 in main()
204 void KisEmbeddedPatternManagerTest::testLoadingOnServerPathNameMd5()
205 {
206 KoResourceServerProvider::instance()->patternServer()->addResource(createPattern(), false);
207 checkOneConfig(PATH, true, "__test_pattern", true);
208 }
209
>>> CID 310996: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
** CID 310995: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_animation_importer_test.cpp: 82 in main()
________________________________________________________________________________________________________
*** CID 310995: Error handling issues (UNCAUGHT_EXCEPT)
/home/boud/dev/krita/libs/ui/tests/kis_animation_importer_test.cpp: 82 in main()
76 QVERIFY(TestUtil::compareQImages(pt, source2, imported2));
77 QVERIFY(TestUtil::compareQImages(pt, source3, imported3));
78
79 KisPart::instance()->removeDocument(document.data(), false);
80 }
81
>>> CID 310995: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "KisAssertException" is thrown and never caught.
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoiVvSSc0Ywjss83d7yOEUgcCB0VGS755ZaA-2FhoVtwbuw-3D-3D8Z-x_9IaX5f-2FHpKL9E6YDsrt7GXrayr4Tk6CKCUhJvkNHrt7yDf-2BzlxuyfMOLjQZMRcl95033jYymTfk5RaLFNYt6zAFWgfk0d1wPzGSjuZUtS8qEGjUfs9nA-2BWD29lBCXta9wlTKyOO2wTlZuTjsXWWnVTeeJ418AV6VHatGP2649Yv4lG5FdDhoU1XNlHthnibNgGcwjLaUrUkka1UK2XfpN28QjVrw714kwHKZoLdsnJc-3D
More information about the kimageshop
mailing list