Krita Planning: Monday's Week planning session going from April 22, 2019 at 02:00PM till April 22, 2019 at 03:00PM
Wolthera
griffinvalley at gmail.com
Mon Apr 22 15:21:30 BST 2019
>From the past few days, the following points came up:
1. We have no easy way to identify requests that need review, and
while KDE is trying hard to get something done there(the feature only
exists in EE), for the time being, everyone who wants to have their
patch review will need to mark it as 'needs review'.
2. There's a 'merge request template' for merge requests which adds
this label as well as giving a simple checklist that all reviews need
to go through anyhow. Unfortunately we cannot set this as default, so
people will have to select it manually. Setting tempates as default is
a gitlab EE feature only.
3. Issues are disabled. sysadmin would like us to wait until they have
figured out a migration process for them.
4. We will not be using gitlab CI in the foreseeable future: The
Gitlab machine doesn't have enough resources at the moment, and Krita
is a really big program to build. Not that it would help much anyway,
as I cannot remember a time when all our unit tests passed. If you
want to wow me and other Krita devs, make a patch to fix the unit
tests: https://build.kde.org/job/Extragear/job/krita/job/kf5-qt5%20SUSEQt5.10/388/testReport/
5. Some people were worried that 'everyone can merge a merge request'.
This is not true, all KDE contributors with commit access can merge
any merge request, because you have commit access. This is the point
of you having commit access. If you have commit access you have the
ability to really fuck up the plasma/okular/kate git as well. That's
the power KDE gives you. We trust you with that. If you are terrified
of the big green button, mark your requests as 'WIP' with the /wip
quickaction until it is reviewed. (see
https://invent.kde.org/help/user/project/quick_actions.md, in fact,
read the whole manual, it's only an hour or so to read.)
6. There was no chance to discuss the commit messages stuff, most of
the meeting was 1, 2 and 5.
7. Bear in mind that we cannot currently change the gitlab settings,
because gitlab is designed for BDFLs and setting someone to maintainer
gives them waaay too much power according to KDE policy(banning people
from commiting to a repository is supossed to be done by sysadmin, not
by the maintainer).
On Mon, Apr 22, 2019 at 2:30 PM Boudewijn Rempt <boud at valdyas.org> wrote:
>
> On maandag 22 april 2019 14:01:57 CEST griffinvalley at gmail.com wrote:
> > We're in the current period: Monday's Week planning session
> >
> > It will last from April 22, 2019 at 02:00PM till April 22, 2019 at 03:00PM
> >
> > Description:
> >
> > Google Calender URL: http://bit.ly/2DsMCir
> > This is an auto generated message. For questions please contact us on the Krita IRC.
> >
>
> Notes: https://docs.google.com/document/d/1R2OMT9_MwRgS770MZNHfzzHlpBaRZ9ev0xiQ_f53CGU/edit#
>
>
>
> --
> https://www.krita.org
--
Wolthera
More information about the kimageshop
mailing list