[krita] 3rdparty: Comment out ffmpeg for now

[Alvin Wong]

I am not sure if it has been discussed in the past, but here's what I have:
- It is a bit complicated to have the installer download something
from the Internet.
- Having the installer connect to a third-party website can cause
security issue and may violate user privacy (IP address).
- It wouldn't work if the system doesn't have an Internet connection.
(Hypothetically it can happen to IT technicians deploying to computers
within an Intranet.)

Dmitry Kazakov <dimula73 at gmail.com> 於 2018年6月1日週五 下午1:26寫道：
>
> Hi, Boud!
>
> As far as I remember, the initial idea was just to make Krita Installer automatically download and install FFMPEG from official site. I cannot remember, what was the problem with this approach?
>
> On 30.05.2018 10:35, Boudewijn Rempt wrote:
>
> Git commit e2a5181d08e642a7a6328cb6215911905f979dda by Boudewijn Rempt.
> Committed on 30/05/2018 at 07:33.
> Pushed by rempt into branch 'master'.
>
> Comment out ffmpeg for now
>
> We would need to build our own ffmpeg, stripped from patent-encumbred
> codecs, which would confuse our users even more. Otherwise we are
> going to have real trouble, for instance with Krita in the Windows
> Store.
>
> https://www.ffmpeg.org/legal.html says
>
> Q: Is it perfectly alright to incorporate the whole FFmpeg core into my own commercial product?
>
> A: You might have a problem here. There have been cases where companies
> have used FFmpeg in their products. These companies found out that once
> you start trying to make money from patented technologies, the owners
> of the patents will come after their licensing fees. Notably, MPEG LA
> is vigilant and diligent about collecting for MPEG-related technologies.
>
> So we really need to consider this again :-(
>
> CCMAIL:kimageshop at kde.org
>
> M  +1    -1    3rdparty/CMakeLists.txt
>
> https://commits.kde.org/krita/e2a5181d08e642a7a6328cb6215911905f979dda
>
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 987a66b89c2..568f8056280 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -207,7 +207,7 @@ endif (ENABLE_PYTHON_DEPS OR NOT MINGW)
>
>  if (MSVC OR MINGW)
>      add_subdirectory( ext_drmingw )
> -    add_subdirectory( ext_ffmpeg )
> +#    add_subdirectory( ext_ffmpeg )
>  endif (MSVC OR MINGW)
>
>  if (NOT APPLE)
>
>
> --
> Dmitry Kazakov