[krita] libs/ui/tests: Make the KisDerivedResources test fail properly

Boudewijn Rempt null at kde.org
Tue Jul 24 10:09:10 BST 2018


Git commit d267cdb11dc348b1362e8abef6f33ce611ab2b29 by Boudewijn Rempt.
Committed on 24/07/2018 at 09:07.
Pushed by rempt into branch 'master'.

Make the KisDerivedResources test fail properly

It crashed because of an assert in boost when checking for the
opengl version, which is totally irrelevant. So disable opengl
using KisConfig.

This now shows a probable bug:

FAIL!  : KisDerivedResourcesTest::test() Compared values are not the same
   Actual   (spy[2][0].toInt())                              : 6012
   Expected ((int)KisCanvasResourceProvider::LodAvailability): 6010
   Loc: [/home/boud/dev/krita/libs/ui/tests/kis_derived_resources_test.cpp(114)]

CCMAIL:kimageshop at kde.org

M  +4    -1    libs/ui/tests/kis_derived_resources_test.cpp

https://commits.kde.org/krita/d267cdb11dc348b1362e8abef6f33ce611ab2b29

diff --git a/libs/ui/tests/kis_derived_resources_test.cpp b/libs/ui/tests/kis_derived_resources_test.cpp
index 81381ae948e..13ffb0f3c5c 100644
--- a/libs/ui/tests/kis_derived_resources_test.cpp
+++ b/libs/ui/tests/kis_derived_resources_test.cpp
@@ -34,7 +34,7 @@
 #include <KisViewManager.h>
 #include <kis_paintop_settings.h>
 #include <KoResourcePaths.h>
-
+#include <kis_config.h>
 #include "testutil.h"
 
 void addResourceTypes()
@@ -64,6 +64,9 @@ void addResourceTypes()
     KoResourcePaths::addResourceType("ko_effects", "data", "/effects/");
     KoResourcePaths::addResourceType("tags", "data", "/tags/");
 
+    KisConfig cfg(false);
+    cfg.setUseOpenGL(false);
+
 }
 
 


More information about the kimageshop mailing list