[krita] libs/ui: Remove the PDF export menu option

Boudewijn Rempt boud at valdyas.org
Sat Jan 21 12:47:25 UTC 2017


I've also updated the manual.

On Sat, 21 Jan 2017, Boudewijn Rempt wrote:

> Git commit 30441fda12d6030c73a30d6242f3f6f5053c3688 by Boudewijn Rempt.
> Committed on 21/01/2017 at 12:30.
> Pushed by rempt into branch 'master'.
> 
> Remove the PDF export menu option
> 
> CCBUG:372439
> CCMAIL: kimageshop at kde.org
> 
> People really should use Scribus (http://scribus.net) to make PDF's,
> not Krita, where the the PDF export code depends on QPrinter, which
> just isn't powerful enough.
> 
> Krita is for creating images; for printing stuff, whether to PDF
> or printer, use a dedicated application.
> 
> M  +3    -3    libs/ui/KisMainWindow.cpp
> M  +1    -0    libs/ui/KisMainWindow.h
> 
> https://commits.kde.org/krita/30441fda12d6030c73a30d6242f3f6f5053c3688
> 
> diff --git a/libs/ui/KisMainWindow.cpp b/libs/ui/KisMainWindow.cpp
> index 2e147929637..3aad5717b08 100644
> --- a/libs/ui/KisMainWindow.cpp
> +++ b/libs/ui/KisMainWindow.cpp
> @@ -202,7 +202,7 @@ public:
>      KisAction *saveActionAs {0};
>  //    KisAction *printAction;
>  //    KisAction *printActionPreview;
> -    KisAction *exportPdf {0};
> +//    KisAction *exportPdf {0};
>      KisAction *importAnimation {0};
>      KisAction *closeAll {0};
>  //    KisAction *reloadFile;
> @@ -2243,8 +2243,8 @@ void KisMainWindow::createActions()
>      d->redo = actionManager->createStandardAction(KStandardAction::Redo, this, SLOT(redo()));
>      d->redo->setActivationFlags(KisAction::ACTIVE_IMAGE);
>  
> -    d->exportPdf  = actionManager->createAction("file_export_pdf");
> -    connect(d->exportPdf, SIGNAL(triggered()), this, SLOT(exportToPdf()));
> +//    d->exportPdf  = actionManager->createAction("file_export_pdf");
> +//    connect(d->exportPdf, SIGNAL(triggered()), this, SLOT(exportToPdf()));
>  
>      d->importAnimation  = actionManager->createAction("file_import_animation");
>      d->importAnimation->setActivationFlags(KisAction::IMAGE_HAS_ANIMATION);
> diff --git a/libs/ui/KisMainWindow.h b/libs/ui/KisMainWindow.h
> index 628ea29fdd8..218b5d90422 100644
> --- a/libs/ui/KisMainWindow.h
> +++ b/libs/ui/KisMainWindow.h
> @@ -216,6 +216,7 @@ public Q_SLOTS:
>       */
>      void slotFileSave();
>  
> +    // XXX: disabled
>      KisPrintJob* exportToPdf(QString pdfFileName = QString());
>  
>      void slotProgress(int value);
> 

-- 
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org


More information about the kimageshop mailing list