Review Request 128020: Use the standard naming scheme for the appdata files

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128020/#review95804
-----------------------------------------------------------


Ship it!




Are you sure about this? Krita isn't a "generic component" so I'd expect https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html to apply, and I see in the examples that "gwenview.desktop" is used, not "org.kde.gwenview". I'm not sure where the .desktop part is coming from, anymore. Shouldn't that be removed to make the id inside the file and the id used to name the file the same? And if we need the reverse url thingy, shouldn't it be "org.krita", or isn't that related to the website??

Anyway, I don't really know about appdata, so if you're sure that this follows the spec, please go ahead and push. I'll take care of https://phabricator.kde.org/T2536 before the 3.0 release on Tuesday.

- Boudewijn Rempt


On May 26, 2016, 1:08 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128020/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 1:08 a.m.)
> 
> 
> Review request for Krita Extensions and Boudewijn Rempt.
> 
> 
> Repository: krita
> 
> 
> Description
> -------
> 
> As suggested here: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent
> 
> Also like the rest of KDE projects.
> 
> 
> Diffs
> -----
> 
>   krita/CMakeLists.txt a546a8d 
>   krita/krita.appdata.xml cee1660 
> 
> Diff: https://git.reviewboard.kde.org/r/128020/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20160526/beb32008/attachment-0001.html>