[krita] plugins/paintops/libpaintop/sensors: Fixes T1269: Reverse direction of Distance, Fade and Time sensors.

Wolthera van Hovell tot Westerflier griffinvalley at gmail.com
Wed May 11 12:22:46 UTC 2016


Git commit c596a1d03c65a08f2c5b21d3b161aa46d1d74dbd by Wolthera van Hovell tot Westerflier.
Committed on 11/05/2016 at 12:17.
Pushed by woltherav into branch 'master'.

Fixes T1269: Reverse direction of Distance, Fade and Time sensors.

They now behave as according to the captions on the curve, but might
affect brushes from 2.9 and below. Be sure to reverse the curves for those.

differential revision:D1342
CCMAIL:kimageshop at kde.org

M  +1    -1    plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_distance.cc
M  +1    -1    plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_fade.cpp
M  +1    -1    plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_time.cc

http://commits.kde.org/krita/c596a1d03c65a08f2c5b21d3b161aa46d1d74dbd

diff --git a/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_distance.cc b/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_distance.cc
index a922522..193bbbc 100644
--- a/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_distance.cc
+++ b/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_distance.cc
@@ -42,7 +42,7 @@ qreal KisDynamicSensorDistance::value(const KisPaintInformation&  pi)
                          fmod(m_measuredDistance, m_length) :
                          qMin(m_measuredDistance, (qreal)m_length);
 
-    return 1.0 - m_measuredDistance / m_length;
+    return m_measuredDistance / m_length;
 }
 
 void KisDynamicSensorDistance::reset()
diff --git a/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_fade.cpp b/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_fade.cpp
index 1a5621f..97967204 100644
--- a/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_fade.cpp
+++ b/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_fade.cpp
@@ -47,7 +47,7 @@ qreal KisDynamicSensorFade::value(const KisPaintInformation&  pi)
         }
     }
 
-    qreal result =  1.0 - (m_counter / qreal(m_length));
+    qreal result =  m_counter / qreal(m_length);
     m_counter++;
 
     return result;
diff --git a/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_time.cc b/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_time.cc
index f6bfd30..82fb8e3 100644
--- a/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_time.cc
+++ b/plugins/paintops/libpaintop/sensors/kis_dynamic_sensor_time.cc
@@ -56,7 +56,7 @@ qreal KisDynamicSensorTime::value(const KisPaintInformation&  pi)
             m_time = m_length;
         }
     }
-    return 1.0 - m_time / qreal(m_length);
+    return m_time / qreal(m_length);
 }
 
 void KisDynamicSensorTime::reset()


More information about the kimageshop mailing list