[calligra/calligra/2.9] libs/widgets: Do not localize 'All' resource tag

Boudewijn Rempt boud at valdyas.org
Sat Jun 20 11:22:49 UTC 2015


On Sat, 20 Jun 2015, Dmitry Kazakov wrote:

> Git commit 4e52524519bb145a3778f12aa9eb07bcd8249e5e by Dmitry Kazakov.
> Committed on 20/06/2015 at 10:56.
> Pushed by dkazakov into branch 'calligra/2.9'.
>
> Do not localize 'All' resource tag
>
> It fixes KisPresetSelectorStrip to show presets on localized systems.
>
> Ideally the solution should be the following:
>
> 1) All the tags are KoID
> 2) All the tags are translatable :(
>

This is actually a bigger problem, since originally decided to make our 
tag store compatible with gimp's -- and that didn't support translations 
either.


> BUG:349026
>
> M  +1    -1    libs/widgets/KoResourceTaggingManager.cpp
>
> http://commits.kde.org/calligra/4e52524519bb145a3778f12aa9eb07bcd8249e5e
>
> diff --git a/libs/widgets/KoResourceTaggingManager.cpp b/libs/widgets/KoResourceTaggingManager.cpp
> index 7000cf5..7b1fe8a 100644
> --- a/libs/widgets/KoResourceTaggingManager.cpp
> +++ b/libs/widgets/KoResourceTaggingManager.cpp
> @@ -81,7 +81,7 @@ KoResourceTaggingManager::KoResourceTaggingManager(KoResourceModel *model, QWidg
>     d->model = model;
>
>     d->tagChooser = new KoTagChooserWidget(parent);
> -    d->tagChooser->addReadOnlyItem(i18n("All"));
> +    d->tagChooser->addReadOnlyItem("All"); // not translatable until other tags made translatable!
>     d->tagChooser->addItems(d->model->tagNamesList());
>
>     d->tagFilter = new KoTagFilterWidget(parent);
>


More information about the kimageshop mailing list