[calligra/calligra/2.9] krita/data/paintoppresets: restore broken presets

Scott Petrovic scottpetrovic at gmail.com
Sat Feb 28 13:09:36 UTC 2015 

Almost 90% of all Krita users are on Windows (Google Analytics tells me
this), so everything should really be tested heavily on that OS before we
do any big changes that could impact performance. Was this commit just 100%
reverts? Some of the original presets were unusable on Windows - which is
why there were so many complaints with the 2.9 release.  I tested each
brush preset on Windows to make sure they were responsive with still
achieving the highest quality I could get. The smudge brushes were by far
the worst, but some of the pixel brushes were quite sluggish and
frustrating to use as well.  We cannot ignore the majority of our user
base.

I think the lesson learned is that there is a big performance difference
between Linux and Windows brushes - and we need to be aware of them and
test accordingly. There were also additional properties added to the brush
engine settings in 2.9, so I am sure that played a role with how they are
performing.

Having slow default brushes makes the entire application look bad.If there
are certain brushes that do not work well on Windows, but 'have' to have a
certain quality, it might be best to remove those with the default
installation. A separate "enhanced linux" brush pack might need to be
available separately for linux users.

Scott


On Sat, Feb 28, 2015 at 5:50 AM, Timothée Giet <animtim at gmail.com> wrote:

>  I didn't test in 2.9 on windows, but I had occasions to test them on
> pevious versions and they worked fine, no real difference with linux, and
> nothing of what I changed since then should made them slower. If some
> people have new performance issues that must be some regressions, so
> changing presets is not the best way to fix this.
>
> I made some comparative tests to check before/after and restored presets
> where the quality of the intended line suffer from the changed settings,
> wether it was different softness, different line continuity, or very
> different size...
>
>
> Le 28/02/2015 11:37, Boudewijn Rempt a écrit :
>
> Should we have a different set on Windows and on Linux then? Or did you
> test these presets on Windows, too?
>
> On Sat, 28 Feb 2015, Timothée Giet wrote:
>
> Git commit e10ef71355a4821a58aa6f86fbf7ccda55143d74 by Timothée Giet.
> Committed on 28/02/2015 at 09:40.
> Pushed by timotheegiet into branch 'calligra/2.9'.
>
> restore broken presets
>
> Restore some presets which intended result was broken by recent changes to
> make them faster.
>
> M  +-    --    krita/data/paintoppresets/Airbrush_eraser.kpp
> M  +-    --    krita/data/paintoppresets/Airbrush_linear.kpp
> M  +-    --    krita/data/paintoppresets/Airbrush_linear_noisy.kpp
> M  +-    --    krita/data/paintoppresets/Airbrush_pressure.kpp
> M  +-    --    krita/data/paintoppresets/Basic_circle.kpp
> M  +-    --    krita/data/paintoppresets/Basic_tip_default.kpp
> M  +-    --    krita/data/paintoppresets/Basic_tip_gaussian.kpp
> M  +-    --    krita/data/paintoppresets/Basic_wet.kpp
> M  +-    --    krita/data/paintoppresets/Basic_wet_soft.kpp
> M  +-    --    krita/data/paintoppresets/Block_basic.kpp
> M  +-    --    krita/data/paintoppresets/Block_bristles.kpp
> M  +-    --    krita/data/paintoppresets/Block_fuzzy.kpp
> M  +-    --    krita/data/paintoppresets/Block_mix_tilt.kpp
> M  +-    --    krita/data/paintoppresets/Block_tilt.kpp
> M  +-    --    krita/data/paintoppresets/Block_wet_tilt.kpp
> M  +-    --    krita/data/paintoppresets/Bristle_frottis.kpp
> M  +-    --    krita/data/paintoppresets/Bristles_hairy.kpp
> M  +-    --    krita/data/paintoppresets/Bristles_mix.kpp
> M  +-    --    krita/data/paintoppresets/Bristles_textured.kpp
> M  +-    --    krita/data/paintoppresets/FX_splat_starfield.kpp
> M  +-    --    krita/data/paintoppresets/Ink_brush_25.kpp
> M  +-    --    krita/data/paintoppresets/Ink_circle_05.kpp
> M  +-    --    krita/data/paintoppresets/Ink_circle_10.kpp
> M  +-    --    krita/data/paintoppresets/Ink_tilt_20.kpp
> M  +-    --    krita/data/paintoppresets/Pastel_texture_large.kpp
> M  +-    --    krita/data/paintoppresets/Pastel_texture_thin.kpp
> M  +-    --    krita/data/paintoppresets/Rake_bristle_dry.kpp
> M  +-    --    krita/data/paintoppresets/Rake_texture.kpp
> M  +-    --    krita/data/paintoppresets/Smudge_soft.kpp
> M  +-    --    krita/data/paintoppresets/Sparkle_wet.kpp
> M  +-    --    krita/data/paintoppresets/Splat_mix_cells.kpp
> M  +-    --    krita/data/paintoppresets/Splat_wet_cells.kpp
> M  +-    --    krita/data/paintoppresets/Sponge_texture.kpp
> M  +-    --    krita/data/paintoppresets/Texture_fuzzy.kpp
> M  +-    --    krita/data/paintoppresets/Texture_hair.kpp
> M  +-    --    krita/data/paintoppresets/ink_precision_03.kpp
>
> http://commits.kde.org/calligra/e10ef71355a4821a58aa6f86fbf7ccda55143d74
>
> diff --git a/krita/data/paintoppresets/Airbrush_eraser.kpp
> b/krita/data/paintoppresets/Airbrush_eraser.kpp
> index 1eaad34..71af5ac 100644
> Binary files a/krita/data/paintoppresets/Airbrush_eraser.kpp and
> b/krita/data/paintoppresets/Airbrush_eraser.kpp differ
> diff --git a/krita/data/paintoppresets/Airbrush_linear.kpp
> b/krita/data/paintoppresets/Airbrush_linear.kpp
> index 794428d..1c91d9b 100644
> Binary files a/krita/data/paintoppresets/Airbrush_linear.kpp and
> b/krita/data/paintoppresets/Airbrush_linear.kpp differ
> diff --git a/krita/data/paintoppresets/Airbrush_linear_noisy.kpp
> b/krita/data/paintoppresets/Airbrush_linear_noisy.kpp
> index 24b3f32..50030a0 100644
> Binary files a/krita/data/paintoppresets/Airbrush_linear_noisy.kpp and
> b/krita/data/paintoppresets/Airbrush_linear_noisy.kpp differ
> diff --git a/krita/data/paintoppresets/Airbrush_pressure.kpp
> b/krita/data/paintoppresets/Airbrush_pressure.kpp
> index 2cf4eb6..dc59b22 100644
> Binary files a/krita/data/paintoppresets/Airbrush_pressure.kpp and
> b/krita/data/paintoppresets/Airbrush_pressure.kpp differ
> diff --git a/krita/data/paintoppresets/Basic_circle.kpp
> b/krita/data/paintoppresets/Basic_circle.kpp
> index 2ea2b79..92c5f8d 100644
> Binary files a/krita/data/paintoppresets/Basic_circle.kpp and
> b/krita/data/paintoppresets/Basic_circle.kpp differ
> diff --git a/krita/data/paintoppresets/Basic_tip_default.kpp
> b/krita/data/paintoppresets/Basic_tip_default.kpp
> index 71224a1..d9fd8fa 100644
> Binary files a/krita/data/paintoppresets/Basic_tip_default.kpp and
> b/krita/data/paintoppresets/Basic_tip_default.kpp differ
> diff --git a/krita/data/paintoppresets/Basic_tip_gaussian.kpp
> b/krita/data/paintoppresets/Basic_tip_gaussian.kpp
> index f8ead15..4b0bee9 100644
> Binary files a/krita/data/paintoppresets/Basic_tip_gaussian.kpp and
> b/krita/data/paintoppresets/Basic_tip_gaussian.kpp differ
> diff --git a/krita/data/paintoppresets/Basic_wet.kpp
> b/krita/data/paintoppresets/Basic_wet.kpp
> index 58160d7..84b3a60 100644
> Binary files a/krita/data/paintoppresets/Basic_wet.kpp and
> b/krita/data/paintoppresets/Basic_wet.kpp differ
> diff --git a/krita/data/paintoppresets/Basic_wet_soft.kpp
> b/krita/data/paintoppresets/Basic_wet_soft.kpp
> index 62f5b0a..07bc45d 100644
> Binary files a/krita/data/paintoppresets/Basic_wet_soft.kpp and
> b/krita/data/paintoppresets/Basic_wet_soft.kpp differ
> diff --git a/krita/data/paintoppresets/Block_basic.kpp
> b/krita/data/paintoppresets/Block_basic.kpp
> index 3ceddeb..9dda95d 100644
> Binary files a/krita/data/paintoppresets/Block_basic.kpp and
> b/krita/data/paintoppresets/Block_basic.kpp differ
> diff --git a/krita/data/paintoppresets/Block_bristles.kpp
> b/krita/data/paintoppresets/Block_bristles.kpp
> index 4671161..6615c53 100644
> Binary files a/krita/data/paintoppresets/Block_bristles.kpp and
> b/krita/data/paintoppresets/Block_bristles.kpp differ
> diff --git a/krita/data/paintoppresets/Block_fuzzy.kpp
> b/krita/data/paintoppresets/Block_fuzzy.kpp
> index 0340343..e8cf298 100644
> Binary files a/krita/data/paintoppresets/Block_fuzzy.kpp and
> b/krita/data/paintoppresets/Block_fuzzy.kpp differ
> diff --git a/krita/data/paintoppresets/Block_mix_tilt.kpp
> b/krita/data/paintoppresets/Block_mix_tilt.kpp
> index 94e6121..805825d 100644
> Binary files a/krita/data/paintoppresets/Block_mix_tilt.kpp and
> b/krita/data/paintoppresets/Block_mix_tilt.kpp differ
> diff --git a/krita/data/paintoppresets/Block_tilt.kpp
> b/krita/data/paintoppresets/Block_tilt.kpp
> index e149732..71c809b 100644
> Binary files a/krita/data/paintoppresets/Block_tilt.kpp and
> b/krita/data/paintoppresets/Block_tilt.kpp differ
> diff --git a/krita/data/paintoppresets/Block_wet_tilt.kpp
> b/krita/data/paintoppresets/Block_wet_tilt.kpp
> index ae84271..f13a65d 100644
> Binary files a/krita/data/paintoppresets/Block_wet_tilt.kpp and
> b/krita/data/paintoppresets/Block_wet_tilt.kpp differ
> diff --git a/krita/data/paintoppresets/Bristle_frottis.kpp
> b/krita/data/paintoppresets/Bristle_frottis.kpp
> index 96606f1..c903478 100644
> Binary files a/krita/data/paintoppresets/Bristle_frottis.kpp and
> b/krita/data/paintoppresets/Bristle_frottis.kpp differ
> diff --git a/krita/data/paintoppresets/Bristles_hairy.kpp
> b/krita/data/paintoppresets/Bristles_hairy.kpp
> index 4201c10..589df06 100644
> Binary files a/krita/data/paintoppresets/Bristles_hairy.kpp and
> b/krita/data/paintoppresets/Bristles_hairy.kpp differ
> diff --git a/krita/data/paintoppresets/Bristles_mix.kpp
> b/krita/data/paintoppresets/Bristles_mix.kpp
> index 50b84f4..53a8120 100644
> Binary files a/krita/data/paintoppresets/Bristles_mix.kpp and
> b/krita/data/paintoppresets/Bristles_mix.kpp differ
> diff --git a/krita/data/paintoppresets/Bristles_textured.kpp
> b/krita/data/paintoppresets/Bristles_textured.kpp
> index a09b379..b201331 100644
> Binary files a/krita/data/paintoppresets/Bristles_textured.kpp and
> b/krita/data/paintoppresets/Bristles_textured.kpp differ
> diff --git a/krita/data/paintoppresets/FX_splat_starfield.kpp
> b/krita/data/paintoppresets/FX_splat_starfield.kpp
> index f31e421..55e811d 100644
> Binary files a/krita/data/paintoppresets/FX_splat_starfield.kpp and
> b/krita/data/paintoppresets/FX_splat_starfield.kpp differ
> diff --git a/krita/data/paintoppresets/Ink_brush_25.kpp
> b/krita/data/paintoppresets/Ink_brush_25.kpp
> index 33b6992..7da5475 100644
> Binary files a/krita/data/paintoppresets/Ink_brush_25.kpp and
> b/krita/data/paintoppresets/Ink_brush_25.kpp differ
> diff --git a/krita/data/paintoppresets/Ink_circle_05.kpp
> b/krita/data/paintoppresets/Ink_circle_05.kpp
> index 69bcd39..c3ddd33 100644
> Binary files a/krita/data/paintoppresets/Ink_circle_05.kpp and
> b/krita/data/paintoppresets/Ink_circle_05.kpp differ
> diff --git a/krita/data/paintoppresets/Ink_circle_10.kpp
> b/krita/data/paintoppresets/Ink_circle_10.kpp
> index e2ad4d8..3d165032 100644
> Binary files a/krita/data/paintoppresets/Ink_circle_10.kpp and
> b/krita/data/paintoppresets/Ink_circle_10.kpp differ
> diff --git a/krita/data/paintoppresets/Ink_tilt_20.kpp
> b/krita/data/paintoppresets/Ink_tilt_20.kpp
> index 36c4533..9fc9694 100644
> Binary files a/krita/data/paintoppresets/Ink_tilt_20.kpp and
> b/krita/data/paintoppresets/Ink_tilt_20.kpp differ
> diff --git a/krita/data/paintoppresets/Pastel_texture_large.kpp
> b/krita/data/paintoppresets/Pastel_texture_large.kpp
> index 509322f..fec9608 100644
> Binary files a/krita/data/paintoppresets/Pastel_texture_large.kpp and
> b/krita/data/paintoppresets/Pastel_texture_large.kpp differ
> diff --git a/krita/data/paintoppresets/Pastel_texture_thin.kpp
> b/krita/data/paintoppresets/Pastel_texture_thin.kpp
> index 1962ba6..3b1bfae 100644
> Binary files a/krita/data/paintoppresets/Pastel_texture_thin.kpp and
> b/krita/data/paintoppresets/Pastel_texture_thin.kpp differ
> diff --git a/krita/data/paintoppresets/Rake_bristle_dry.kpp
> b/krita/data/paintoppresets/Rake_bristle_dry.kpp
> index f11a1a2..8d87235 100644
> Binary files a/krita/data/paintoppresets/Rake_bristle_dry.kpp and
> b/krita/data/paintoppresets/Rake_bristle_dry.kpp differ
> diff --git a/krita/data/paintoppresets/Rake_texture.kpp
> b/krita/data/paintoppresets/Rake_texture.kpp
> index e47e89a..dc71cd8 100644
> Binary files a/krita/data/paintoppresets/Rake_texture.kpp and
> b/krita/data/paintoppresets/Rake_texture.kpp differ
> diff --git a/krita/data/paintoppresets/Smudge_soft.kpp
> b/krita/data/paintoppresets/Smudge_soft.kpp
> index a31b541..40c08be 100644
> Binary files a/krita/data/paintoppresets/Smudge_soft.kpp and
> b/krita/data/paintoppresets/Smudge_soft.kpp differ
> diff --git a/krita/data/paintoppresets/Sparkle_wet.kpp
> b/krita/data/paintoppresets/Sparkle_wet.kpp
> index 0efb10b..886727a 100644
> Binary files a/krita/data/paintoppresets/Sparkle_wet.kpp and
> b/krita/data/paintoppresets/Sparkle_wet.kpp differ
> diff --git a/krita/data/paintoppresets/Splat_mix_cells.kpp
> b/krita/data/paintoppresets/Splat_mix_cells.kpp
> index 39c0939..5b06d43 100644
> Binary files a/krita/data/paintoppresets/Splat_mix_cells.kpp and
> b/krita/data/paintoppresets/Splat_mix_cells.kpp differ
> diff --git a/krita/data/paintoppresets/Splat_wet_cells.kpp
> b/krita/data/paintoppresets/Splat_wet_cells.kpp
> index 44dbfad..57dbf80 100644
> Binary files a/krita/data/paintoppresets/Splat_wet_cells.kpp and
> b/krita/data/paintoppresets/Splat_wet_cells.kpp differ
> diff --git a/krita/data/paintoppresets/Sponge_texture.kpp
> b/krita/data/paintoppresets/Sponge_texture.kpp
> index d277236..ad92974 100644
> Binary files a/krita/data/paintoppresets/Sponge_texture.kpp and
> b/krita/data/paintoppresets/Sponge_texture.kpp differ
> diff --git a/krita/data/paintoppresets/Texture_fuzzy.kpp
> b/krita/data/paintoppresets/Texture_fuzzy.kpp
> index 0193145..c7baf08 100644
> Binary files a/krita/data/paintoppresets/Texture_fuzzy.kpp and
> b/krita/data/paintoppresets/Texture_fuzzy.kpp differ
> diff --git a/krita/data/paintoppresets/Texture_hair.kpp
> b/krita/data/paintoppresets/Texture_hair.kpp
> index db61166..caabbc3 100644
> Binary files a/krita/data/paintoppresets/Texture_hair.kpp and
> b/krita/data/paintoppresets/Texture_hair.kpp differ
> diff --git a/krita/data/paintoppresets/ink_precision_03.kpp
> b/krita/data/paintoppresets/ink_precision_03.kpp
> index a53a1fc..1d78992 100644
> Binary files a/krita/data/paintoppresets/ink_precision_03.kpp and
> b/krita/data/paintoppresets/ink_precision_03.kpp differ
>
>
>
> _______________________________________________
> Krita mailing listkimageshop at kde.orghttps://mail.kde.org/mailman/listinfo/kimageshop
>
>
>
> _______________________________________________
> Krita mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20150228/8cee3e0a/attachment-0001.html>

More information about the kimageshop mailing list