[calligra/calligra/2.9] krita/plugins/tools/defaulttools: add label to smoothing property so it is more consistent with other options

[Dmitry Kazakov]

Hi, Scott!

I'm not sure this very change looks ok (probably, it might be fixed somehow
without reverting the patch, I don't know).

Before the change the combo box had a fixed width. That is whatever option
was selected it kept the same look, and therefore looked more highlevel
option that the rest of the list

After your patch the width of the dropdown box is no longer fixed and it
changes its size when the user clicks on it (to select another type of
smoothing). In my opinion such jumping-under-cursor controls look quite
ugly. I feel that we should still show somehow that the type of smoothing
is more highlevel option.



On Thu, Feb 5, 2015 at 6:52 AM, Scott Petrovic <scottpetrovic at gmail.com>
wrote:

> Git commit fb929a857ceb75bfcf96543b935749d4e3ac0877 by Scott Petrovic.
> Committed on 05/02/2015 at 03:52.
> Pushed by scottpetrovic into branch 'calligra/2.9'.
>
> add label to smoothing property so it is more consistent with other options
>
> M  +7    -4    krita/plugins/tools/defaulttools/kis_tool_brush.cc
> M  +2    -0    krita/plugins/tools/defaulttools/kis_tool_brush.h
>
> http://commits.kde.org/calligra/fb929a857ceb75bfcf96543b935749d4e3ac0877
>
> diff --git a/krita/plugins/tools/defaulttools/kis_tool_brush.cc
> b/krita/plugins/tools/defaulttools/kis_tool_brush.cc
> index 40dfd14..8db9ba0 100644
> --- a/krita/plugins/tools/defaulttools/kis_tool_brush.cc
> +++ b/krita/plugins/tools/defaulttools/kis_tool_brush.cc
> @@ -318,14 +318,17 @@ QWidget * KisToolBrush::createOptionWidget()
>      optionsWidget->layout()->addWidget(specialSpacer);
>
>      // Line smoothing configuration
> +    m_smoothingLabel = new QLabel(optionsWidget);
> +    m_smoothingLabel->setText(i18n("Smoothing:"));
> +
>      m_cmbSmoothingType = new QComboBox(optionsWidget);
>      m_cmbSmoothingType->addItems(QStringList()
> -            << i18n("No Smoothing")
> -            << i18n("Basic Smoothing")
> -            << i18n("Weighted Smoothing")
> +            << i18n("None")
> +            << i18n("Basic")
> +            << i18n("Weighted")
>              << i18n("Stabilizer"));
>      connect(m_cmbSmoothingType, SIGNAL(currentIndexChanged(int)), this,
> SLOT(slotSetSmoothingType(int)));
> -    addOptionWidgetOption(m_cmbSmoothingType);
> +    addOptionWidgetOption(m_cmbSmoothingType, m_smoothingLabel);
>
>      m_sliderSmoothnessDistance = new
> KisDoubleSliderSpinBox(optionsWidget);
>      m_sliderSmoothnessDistance->setRange(3.0,
> MAXIMUM_SMOOTHNESS_DISTANCE, 1);
> diff --git a/krita/plugins/tools/defaulttools/kis_tool_brush.h
> b/krita/plugins/tools/defaulttools/kis_tool_brush.h
> index 161b248..08419a1 100644
> --- a/krita/plugins/tools/defaulttools/kis_tool_brush.h
> +++ b/krita/plugins/tools/defaulttools/kis_tool_brush.h
> @@ -34,6 +34,7 @@
>
>  class QCheckBox;
>  class QComboBox;
> +class QLabel;
>  class QGridLayout;
>
>  class KoCanvasBase;
> @@ -115,6 +116,7 @@ private:
>      void addSmoothingAction(int enumId, const QString &id, const QString
> &name, KActionCollection *globalCollection);
>
>  private:
> +    QLabel *m_smoothingLabel;
>      QComboBox *m_cmbSmoothingType;
>
>      QCheckBox *m_chkAssistant;
>
>


-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20150206/1bc182e5/attachment.html>