Junior Job (Bug 245658)

Bol Bib bollebib at hotmail.com
Tue Mar 25 13:33:05 UTC 2014


looks great 

I would welcome this
I assume more colorse will be added interactively? is this possible ? Or will it be better to have a fixed RMB panel with empty orbs?




if I could suggest that this design could also work with this

https://bugs.kde.org/show_bug.cgi?id=328482

or something similar to complement that color history design.

Like the "settings orb" you have,this could be a permanent button that triggers that function.

maybe it just toggles to show the available RMB palettes by replacing color history orbs and showing the saved RMB palettes in their stead.


Ofcourse there could be a totally different solution for this as well,just though it sounded kinda similar to my idea,so I wanted to mention it.




Date: Tue, 25 Mar 2014 13:23:12 +0100
From: animtim at gmail.com
To: kimageshop at kde.org
Subject: Re: Junior Job (Bug 245658)


  
    
  
  
    Nice work,

      And very good idea to expand this to color history. Also the
      config button can open the "select favorite preset" window, with
      maybe more options to further customize it like color selector
      type..

      

      +1 

      

      Le 25/03/2014 13:10, David Revoy a écrit :

    
    
      
        
          
            
              Really nice this way.

              
              I think it's done :-)

              

            
            This new 'petal' design around the pop-up made me think of a
            design idea. 

          
          To artist/user on mailing-list please give a review to this
          ideas mockup : http://i.imgur.com/46cYJTL.png

        
        i don't know if you would find this attractive.

        

          
            
              

              
            
          
        
      
      
        _____________________

            http://www.davidrevoy.com

        
        

        

        On Tue, Mar 25, 2014 at 12:37 PM,
          Koushik S <skoushik333 at gmail.com>
          wrote:

          
            
              
                
                  Thanks for the feedback, David.

                    

                  
                  Here's the updated look : http://i.imgur.com/84Q2n60.png

                  

                
                I'm not exactly sure if it was the right way to do it. I
                just decreased the color area, while keeping the mask
                region the same, which seems to be the same way the
                border around the palette is generated. 

              
            
            
              
                

                  

                  On Tue, Mar 25, 2014 at 2:21
                    PM, David Revoy <davidrevoy at gmail.com>
                    wrote:

                    
                      
                        Hi, it does look good to me. :-)

                        
                        ( only crit : maybe it needs also a black
                        outline around, as the main widget got one too )

                      
                      
                        _____________________

                            http://www.davidrevoy.com

                        
                        

                        

                        
                          
                            On Mon, Mar 24, 2014 at 6:58 PM,
                              Koushik S <skoushik333 at gmail.com>
                              wrote:

                            
                          
                          
                            
                              
                                
                                  
                                    Hi,

                                      

                                    
                                        I was working on and off on this
                                    bug, and here are the developments
                                    on this so far. I have been able to
                                    create a separate area for the FG
                                    colour to be displayed. 

                                    

                                        Here's what I've come up with so
                                    far: http://i.imgur.com/UqyjdZl.png

                                    

                                  
                                      Any feedbacks are welcomed. 

                                
                                
                                  
                                    

                                      

                                      On Sat,
                                        Mar 15, 2014 at 7:22 PM, Koushik
                                        S <skoushik333 at gmail.com>
                                        wrote:

                                        
                                          
                                            
                                              

                                                On
                                                  Sat, Mar 15, 2014 at
                                                  4:57 PM, Sven Langkamp
                                                  <sven.langkamp at gmail.com>
                                                  wrote:

                                                  It's
                                                    hard to tell what
                                                    you are trying to
                                                    do. Can you attach
                                                    the code and a
                                                    screenshot?
                                                
                                                

                                              
                                            
                                            Sure.
                                              Here's the code snippet I
                                              added in the paintEvent.

                                              

                                            
                                            <code>

                                              //painting foreground
                                              color

                                                  QPainterPath path2;

                                                 
                                              path2.addEllipse(QPoint(180,180),
                                              colorInnerRadius-25,
                                              colorInnerRadius - 25);

                                                 
                                              painter.fillPath(path2,
                                              m_triangleColorSelector->color());

                                                 
                                              painter.drawPath(path2);

                                            
                                            </code>

                                            
                                            
                                            
                                            
                                              I've also added in some
                                              modifications to the
                                              masks. The size of the
                                              masks and also the path
                                              are arbitrary and are just
                                              used for testing. 

                                              

                                            
                                            <code>

                                            
                                            
                                                  int side =
                                              qMin(width()/2,
                                              height()/2);

                                            
                                               
                                              int side2 =
                                              qMin(width()/2,
                                              height()/2);

                                                  QRegion maskedRegion
                                              (width()/2 - side/2,
                                              height()/2 - side/2, side,
                                              side, QRegion::Ellipse);

                                                  QRegion maskedRegion2
                                              (180 - side2/2, 180 -
                                              side2/2 , side2, side2,
                                              QRegion::Ellipse);

                                                  setMask(maskedRegion +
                                              maskedRegion2);

                                            
                                            </code>

                                            
                                            

                                            
                                            These
                                              wouldn't work since, the
                                              QRect which houses only
                                              the popup palette. I
                                              couldn't figure out the
                                              part of the code which
                                              changes the QRect size. 

                                              

                                            
                                            
                                              But, as I've been going
                                              through it, changing the
                                              size in the sizeHint()
                                              method seems to change the
                                              overall size of the widget
                                              i.e., it enlarges it. So,
                                              I probably should change
                                              most of the code which
                                              calculates the relative
                                              positions of the favourite
                                              brushes and so on. Is it
                                              the right way to do it? 

                                              
                                                
                                            
                                                

                                                  -- 

                                                  
                                                    regards,
                                                    Koushik. S
                                                
                                              
                                        
                                      
                                      

                                      
                                      

                                    
                                  
                                  -- 

                                      
                                        regards,
                                        Koushik. S
                                    
                                

                              
                            
                            _______________________________________________

                              Krita mailing list

                              kimageshop at kde.org

                              https://mail.kde.org/mailman/listinfo/kimageshop

                              

                            
                          
                        
                        

                      
                      

                      _______________________________________________

                      Krita mailing list

                      kimageshop at kde.org

                      https://mail.kde.org/mailman/listinfo/kimageshop

                      

                    
                  
                  

                  
                  

                
              
              -- 

                  
                    regards,
                    Koushik. S
                
            

            _______________________________________________

            Krita mailing list

            kimageshop at kde.org

            https://mail.kde.org/mailman/listinfo/kimageshop

            

          
        
        

      
      

      
      

      _______________________________________________
Krita mailing list
kimageshop at kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

    
    

  


_______________________________________________
Krita mailing list
kimageshop at kde.org
https://mail.kde.org/mailman/listinfo/kimageshop 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20140325/0b510666/attachment-0001.html>


More information about the kimageshop mailing list