Patch to implement resource categorization via tags
s_suelzer at lavabit.com
s_suelzer at lavabit.com
Tue May 14 17:15:08 UTC 2013
On Tue, May 14, 2013 at 06:33:52PM +0200, Sven Langkamp wrote:
> Overall pretty nice work.
> There are a few minor things I spotted:
> - that empty slot in PresetDockerDock can be removed completely including
> the connections
> - there were some coding styles issues with missing spaces between
> methods
> - KoPresetFiltering has a misleading name, at that level we don't have
> presets just resources
> - some strings are missing the i18n() around it
> - this does a bit to much in one line, I think: dirty? ++m_changeCounter :
> m_oldChangeCounter = m_changeCounter;
>
> As this is a Calligra wide change, it should go through reviewboard.
Thank you for the reply. I will post an amended patch there, then.
More information about the kimageshop
mailing list