Proof of concept patch for Wash Mode artifacts

[Dmitry Kazakov]

Hi, Lukas!

Just checked: it doesn't fix that bug :( Looks like this is some other
problem.

On Mon, Jun 17, 2013 at 11:12 PM, Lukast dev <lukast.dev at gmail.com> wrote:

> Hi Dmitry,
>
> can you check if this fixes also this bug?
> https://bugs.kde.org/show_bug.cgi?id=300665
>
> Lukas
>
> 2013/6/16 Dmitry Kazakov <dimula73 at gmail.com>:
> > Hi!
> >
> > One of the bugs I'm working on currently is Wash Mode bug, described by
> Paul
> > in the first part of the bug [0].
> >
> > Technical part:
> >
> > Actually, this is not a bug, but a flaw of the composition formula we
> use in
> > ALPHA_DARKEN composite op. So to fix this bug, we need to change the
> formula
> > (with all the obvious consequences). The problem is this formula is not
> > commutative, that is the order of application of dabs changes the result
> > dramatically.
> >
> > The patch:
> >
> > In the attachment you can find a patch which (should) fix this bug. It
> would
> > be nice if someone tested it and looked for some non-obvious regressions
> in
> > painting it introduces.
> >
> > This patch implements:
> > 1) Fixes the artifacts on the tail of the Wash Mode stroke
> >
> > This patch breaks (known issues):
> > 1) Flow option doesn't work (it is simply disabled)
> > 2) It fixes the bug for a Pixel Brush only
> > 3) It disables vector optimizations
> >
> >
> > [0] - https://bugs.kde.org/show_bug.cgi?id=320651
> >
> > --
> > Dmitry Kazakov
> > _______________________________________________
> > Krita mailing list
> > kimageshop at kde.org
> > https://mail.kde.org/mailman/listinfo/kimageshop
> >
> _______________________________________________
> Krita mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>



-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20130618/cd2d3ff0/attachment.html>