improvement in metadata properties of an image

Boudewijn Rempt boud at valdyas.org
Mon Apr 1 09:08:21 UTC 2013


On Monday 01 April 2013 Apr 10:31:34 Kanika Singhal wrote:
> Hello,
> When i was working on Krita I found that it doesn't provide sufficient
> information of metadata of an image. Also while editing the metadata  of an
> image it doesn't have a capability of editing IPTC an XMP. I want to
> contribute to Outreach Program for women. Can u please suggest me from
> where I can start.

I just found out that the existing medatadata editor was accidentally disabled. This patch enables it:

commit f0d59823f736945c9cac7b2f9111c164c9e5267d
Author: Boudewijn Rempt <boud at valdyas.org>
Date:   Mon Apr 1 10:56:11 2013 +0200

    Re-enable the metadata editor
    
    If the compile version and runtime version are the same, we enable
    the action, not disable it.

diff --git a/krita/plugins/extensions/metadataeditor/metadataeditor.cc b/krita/plugins/extensions/metadataeditor/metadataeditor.cc
index 1507bad..c8830cc 100644
--- a/krita/plugins/extensions/metadataeditor/metadataeditor.cc
+++ b/krita/plugins/extensions/metadataeditor/metadataeditor.cc
@@ -60,7 +60,7 @@ metadataeditorPlugin::metadataeditorPlugin(QObject *parent, const QVariantList &
     QStringList runtimeVersion = QString(qVersion()).split('.');
     QStringList compileVersion = QString(QT_VERSION_STR).split('.');
 
-    if (runtimeVersion[1] == compileVersion[1]) {
+    if (runtimeVersion[1] != compileVersion[1]) {
         action->setActivationFlags(KisAction::NEVER_ACTIVATE);
     }
 }
lines 1-22/22 (END)

However, the big picture is like this: Krita has a big and extensible metadata framework, but it has not seen a lot of maintenance and could use a lot of love. One problem is that the metadata framework is designed to assert on encountering unknown tags, another problem is that various file format plugins have varying degrees of support for metadata. And a third problem is that some versions of libraries, like jpeg8, trigger code paths that weren't triggered earlier. (In this case, we should make it impossible to compile against that version of libjpeg).

What you probably should do is

a) investigate what your problem is, exactly, and report that on bugs.kde.org. We do load and save metadata for, for instance, jpeg files, and there is an xmp/iptc/exif metadata editor in the jpeg export filter, as well as in the layers menu for file types with metadata. So there is support, but there might be issues.

b) show us that you have the necessary C++ and Qt skills. We can do a lot of training on the job, but without a good base, hacking on the metadata system won't work out. That means we need to see some code for Krita,

c) create a plan for fixing and maintaining the metadata system in Krita. That needs to be done on this mailing list so we can have the input from all project members and the original author, Cyrille Berger.

d) try to get into the OPW program :-). That's likely hardest!

Please note that for Krita, there is also the possibility of summer of code work.


More information about the kimageshop mailing list