[calligra] krita/plugins/paintops: Force a minimum brush spacing of 0.1

Boudewijn Rempt boud at valdyas.org
Tue Mar 6 11:07:25 UTC 2012


Git commit 52ebb50a5b8fb0c8c5162c60253a2c4f3ea59290 by Boudewijn Rempt.
Committed on 06/03/2012 at 12:06.
Pushed by rempt into branch 'master'.

Force a minimum brush spacing of 0.1

CCMAIL:kimageshop at kde.org

I notice that we still have a lot of brushes that have a default spacing
of 0, which simply doesn't perform in Krita. This commit makes the
minumum value 0.1. Big brushes as used in the Texture_paint_noisy_big
preset now actually work in real-time.

Should this be backported to 2.4?

M  +1    -0    krita/plugins/paintops/libbrush/kis_brush.cpp
M  +1    -1    krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp

http://commits.kde.org/calligra/52ebb50a5b8fb0c8c5162c60253a2c4f3ea59290

diff --git a/krita/plugins/paintops/libbrush/kis_brush.cpp b/krita/plugins/paintops/libbrush/kis_brush.cpp
index 4054540..3a24927 100644
--- a/krita/plugins/paintops/libbrush/kis_brush.cpp
+++ b/krita/plugins/paintops/libbrush/kis_brush.cpp
@@ -349,6 +349,7 @@ double KisBrush::ySpacing(double scale) const
 
 void KisBrush::setSpacing(double s)
 {
+    if (s < 0.1) s = 0.1;
     d->spacing = s;
 }
 
diff --git a/krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp b/krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp
index 2d414fc..af31cf7 100644
--- a/krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp
+++ b/krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp
@@ -110,7 +110,7 @@ KisBrushChooser::KisBrushChooser(QWidget *parent, const char *name)
 
     m_lbSpacing = new QLabel(i18n("Spacing: "), this);
     m_slSpacing = new KisDoubleSliderSpinBox(this);
-    m_slSpacing->setRange(0.0, 10, 2);
+    m_slSpacing->setRange(0.1, 10, 2);
     m_slSpacing->setValue(0.1);
     m_slSpacing->setExponentRatio(3.0);
     QObject::connect(m_slSpacing, SIGNAL(valueChanged(qreal)), this, SLOT(slotSetItemSpacing(qreal)));


More information about the kimageshop mailing list