[calligra] krita/ui/tool: end gesture when shift key is released

[Sven Langkamp]

On Thu, Dec 27, 2012 at 1:16 PM, Boudewijn Rempt <boud at valdyas.org> wrote:
> On Thu, 27 Dec 2012, Sven Langkamp wrote:
>
>> On Mon, Dec 24, 2012 at 7:05 PM, Dmitry Kazakov <dimula73 at gmail.com>
>> wrote:
>>>
>>> Hi!
>>>
>>> Didn't it finish the gesture when the mouse button was released? Because
>>> I
>>> remember I wanted it to allow user to to the following kind of gesture:
>>>
>>> 1) Press Shift key
>>> 2) Start Mouse Drag operation
>>> 3) Release Shift key or press *any* other keys --- the dragging will
>>> persist
>>> till you release the mouse.
>>> 4) Release the moube button --- this is the point when the gesture is
>>> stopped.
>>>
>>> I guess, this was quite a convenient approach.
>>>
>>> This patch breaks this behavior. Could you tell, which bug did you fix?#
>>
>>
>> I changed that based on feedback from Roey on IRC. He wanted to also
>> have the gesture abort when the key is released.
>>
>
> Hm... I'm not sure actually that the original behaviour Dmitry implemented
> wasn't exactly what Deevad and Animtim had asked for.

Until recently the the gesture was only stopped when you released key
and mouse button. Then someone did request that is should stop on
mouse and now also on key up. We haven't defined the whole interaction
behavior, so there are certainly places were it's not clear if it's
not yet implemented or intentional.