https://bugs.kde.org/show_bug.cgi?id=281761 -- scaling between channel sizes

Mon Sep 19 08:08:13 UTC 2011

On Sunday 18 September 2011 Sep, Silvio Heinrich wrote:
> On 09/18/2011 03:06 PM, Boudewijn Rempt wrote:
> > hi,
> >
> > I'm stuck with this bug... Could someone with adequate templating foo please check my patch and help me out a bit? I get a crash now if I follow the instructions in the bug report exactly.
> 
> Ok I got it. Now it seems to work.
> Now just one part is missing.
> We need to test if the destination colorspace uses floating point 
> channels so that the second part of the "else" part is executed.

Looks good! I think we can skip the check for floating point, though, since KoColorSpaceAbstract isn't used as a base class for floating point colorspaces, we use ctlcs for that. Otherwise, it would be simple enough -- we can check for the type of the first channel, since KoColorSpaceAbstract is guaranteed to be homogenous.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl