[calligra] krita: Fix the checkbox behavior of the composite op combobox.

Sven Langkamp sven.langkamp at gmail.com
Thu Sep 15 13:31:50 UTC 2011


On Wed, Sep 14, 2011 at 3:42 PM, Silvio Heinrich <plassy at web.de> wrote:

> Git commit 8d7c720adfed69ec93b8440b8d1448397910af53 by Silvio Heinrich.
> Committed on 14/09/2011 at 15:40.
> Pushed by heinrich into branch 'master'.
>
> Fix the checkbox behavior of the composite op combobox.
>
> M  +1    -1
>  krita/plugins/paintops/libpaintop/kis_paintop_options_widget.cpp
> M  +33   -22   krita/ui/kis_categorized_item_delegate.cpp
> M  +4    -5    krita/ui/kis_categorized_item_delegate.h
> M  +2    -0    krita/ui/kis_categorized_list_model.h
> M  +21   -3    krita/ui/widgets/kis_categorized_list_view.cpp
> M  +6    -1    krita/ui/widgets/kis_categorized_list_view.h
> M  +20   -3    krita/ui/widgets/kis_cmb_composite.cc
> M  +4    -0    krita/ui/widgets/kis_cmb_composite.h
> M  +1    -1    krita/ui/widgets/kis_paintop_list_widget.cpp
>
> http://commits.kde.org/calligra/8d7c720adfed69ec93b8440b8d1448397910af53
>

Why did you change the delegate to use the menu item style? With oxygen
theme it looks quite ugly as there is some gray on white. I would prefer to
use the standard style for combobox as we had it before. Otherwise it would
have to be changed to be completely like a menu, but currently it's
somewhere in between.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20110915/1d6c5155/attachment.html>


More information about the kimageshop mailing list