[calligra] krita: Removed some more setDirty calls during loading
Cyrille Berger Skott
cberger at cberger.net
Sun Nov 13 12:55:40 UTC 2011
Hi,
I get two new test failures following that commits (and
e4fc0ba0ae301243b4a1a455e7115b1b669e7536 and
ee20b72fb5c4df43285ecb697b4b8fe73187e049):
krita-image-KisCloneLayerTest
http://my.cdash.org/testDetails.php?test=7962766&build=258622
krita-image-KisWalkersTest
http://my.cdash.org/testDetails.php?test=7962782&build=258622
On Sunday 13 November 2011, Dmitry Kazakov wrote:
> Git commit efdb85c83cfac05d987b04679224a60c50c7efff by Dmitry Kazakov.
> Committed on 12/11/2011 at 17:02.
> Pushed by dkazakov into branch 'master'.
>
> Removed some more setDirty calls during loading
>
> Made an update in slotLoadingFinished synchronous
>
> M +0 -5 krita/image/kis_change_profile_visitor.h
> M +1 -0 krita/ui/kis_doc2.cc
>
> http://commits.kde.org/calligra/efdb85c83cfac05d987b04679224a60c50c7efff
>
> diff --git a/krita/image/kis_change_profile_visitor.h
> b/krita/image/kis_change_profile_visitor.h index 4e73161..5bf4bb1 100644
> --- a/krita/image/kis_change_profile_visitor.h
> +++ b/krita/image/kis_change_profile_visitor.h
> @@ -66,7 +66,6 @@ public:
> child->accept(*this);
> child = dynamic_cast<KisLayer*>(child->nextSibling().data());
> }
> - layer->setDirty();
> return true;
> }
>
> @@ -81,7 +80,6 @@ public:
>
> bool visit(KisAdjustmentLayer * layer) {
> layer->resetCache();
> - layer->setDirty();
> return true;
> }
>
> @@ -111,10 +109,7 @@ private:
> const KoColorSpace * cs = layer->paintDevice()->colorSpace();
>
> if (*cs == *m_oldColorSpace) {
> -
> layer->paintDevice()->setProfile(m_dstColorSpace->profile());
> -
> - layer->setDirty();
> }
>
> return true;
> diff --git a/krita/ui/kis_doc2.cc b/krita/ui/kis_doc2.cc
> index 4edc8fa..4f6fb20 100644
> --- a/krita/ui/kis_doc2.cc
> +++ b/krita/ui/kis_doc2.cc
> @@ -173,6 +173,7 @@ QByteArray KisDoc2::mimeType() const
>
> void KisDoc2::slotLoadingFinished() {
> image()->initialRefreshGraphAsync();
> + image()->waitForDone();
> setAutoSave(KisConfig().autoSaveInterval());
> }
--
Cyrille Berger Skott
More information about the kimageshop
mailing list