our failing unittests...

[Boudewijn Rempt]

On Monday 07 March 2011, Dmitry Kazakov wrote:
> On Mon, Mar 7, 2011 at 8:49 AM, Boudewijn Rempt <boud at valdyas.org> wrote:
> 
> > These tests fail:
> >
> >         63 - krita-image-KisIteratorTest (Failed)
> >
> > *** glibc detected *** ./KisIteratorTest: malloc(): memory corruption:
> > 0x117d6ae8 ***
> > QFATAL : KisIteratorTest::stressTest() ASSERT failure in QMutexLocker:
> > "QMutex pointer is misaligned", file /usr/include/QtCore/qmutex.h, line 100
> > FAIL!  : KisIteratorTest::stressTest()
> >
> 
> Well, i'm actually not sure what we should do with this test. The stress
> test was added to prove that atm noone can shift the device while someone is
> reading it. And the test proves it, obviously ;)
>
> The problem is, we need to make a decision on how our iterators should work:
> either they allow interleaving shift or not. Even if we say they "allow" it,
> it will be quite difficult to make them do anything sane while this shift.
> So this "allow" will probably just mean "do not crash".

Hm... I'm not totally sure what you mean with interleaving shift -- do you mean iterators that write on overlapping areas?

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org