[Calligra] eb493aa check whether the image wsp is valid

[Sven Langkamp]

On Wed, Jan 5, 2011 at 12:43 PM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Wednesday 05 January 2011, Sven Langkamp wrote:
> > On Wed, Jan 5, 2011 at 10:41 AM, Boudewijn Rempt <boud at valdyas.org>
> wrote:
> >
> > > commit eb493aa2b562b0a384899b2327501ac058171aaf
> > > branch master
> > > Author: Boudewijn Rempt <boud at valdyas.org>
> > > Date:   Wed Jan 5 10:36:19 2011 +0100
> > >
> > >    check whether the image wsp is valid
> > >
> > >    We should check whether a weak shared pointer is valid, instead
> > >    of checking the pointer -- which isn't set to 0 after the
> corresponding
> > >    shared pointer is deleted.
> > >
> > >    Should be backported to 2.3.
> > >
> > >    CCMAIL:kimageshop at kde.org <CCMAIL%3Akimageshop at kde.org> <
> CCMAIL%3Akimageshop at kde.org <CCMAIL%253Akimageshop at kde.org>>
> > >
> > >    BUG:261940
> > >
> >
> > I don't think that this is the complete fix. The problem indicates that
> > there is an old layer from a now invalid image still around.
>
> I've got some more patches I just committed -- that should make it both
> safe and clean.
>

Shouldn't it also clear the node and layer managers? Can't check that right
now.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20110105/99c010e8/attachment.htm