[calligra] krita: only show filter dialog if the filter has a configuration widget

Boudewijn Rempt boud at valdyas.org
Fri Feb 25 09:24:21 CET 2011


On Friday 25 February 2011, Cyrille Berger Skott wrote:
> On Wednesday 23 February 2011, Sven Langkamp wrote:
> > Git commit 97b361b920d662b723f76f9a3a8a3065c502e91a by Sven Langkamp.
> > Committed on 23/02/2011 at 18:00.
> > Pushed by langkamp into branch 'master'.
> > 
> > only show filter dialog if the filter has a configuration widget
> 
> Hum. The idea to show the dialog was to show a preview for the filter (even 
> allowing browsing if you are not satisfied with the current result), and also 
> that dialog is supposed to have a "create mask" button. With that change, it 
> would make it an unreliable way to create a filter mask. Also breaking the 
> consitency between filters.

I think I agree with Cyrille here.

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org


More information about the kimageshop mailing list