some code warnings

Boudewijn Rempt boud at valdyas.org
Mon Dec 5 12:20:49 UTC 2011


On Monday 05 December 2011 Dec, Jaime wrote:
>   * There is a return in the middle of void
> KisFilterBumpmap::process(KisPaintDeviceSP device, const QRect&
> applyRect, const KisFilterConfiguration* config, KoUpdater*
> progressUpdater) const (line 225)
> in krita/plugins/filters/bumpmap/bumpmap.cpp

Oh my... Good catch -- and that return has been there for three years now! Which makes it unsurprising that if I remove the return, the bumpmap filter turns out to be completely broken :-(


-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl


More information about the kimageshop mailing list