Speed of Krita 2.4

[David REVOY]

I tried to apply the patch to test it , but the terminal answer me :

"
patching file krita/plugins/paintops/libbrush/kis_brush.cpp
Hunk #1 FAILED at 625.
1 out of 1 hunk FAILED -- saving rejects to file 
krita/plugins/paintops/libbrush/kis_brush.cpp.rej
"

Maybe the modification can be applied to master branch ; it will be 
easier to test.



On 03/08/11 01:27, Timothée Giet wrote:
> So for me that's ok, test looks good (I tried painting with my presets 
> that use rough predefined brushes and several sensors, and with simple 
> small round dots, result looks fine; and of course it's much faster).
> Waiting for Ramon and Deevad opinion to confirm.
>
>
> 2011/8/3 Sven Langkamp <sven.langkamp at gmail.com 
> <mailto:sven.langkamp at gmail.com>>
>
>     On Tue, Aug 2, 2011 at 5:09 PM, Sven Langkamp
>     <sven.langkamp at gmail.com <mailto:sven.langkamp at gmail.com>> wrote:
>
>         On Mon, Aug 1, 2011 at 11:42 PM, Sven Langkamp
>         <sven.langkamp at gmail.com <mailto:sven.langkamp at gmail.com>> wrote:
>
>             On Sat, Jul 30, 2011 at 11:41 AM, Silvio Heinrich
>             <plassy at web.de <mailto:plassy at web.de>> wrote:
>
>                 Am 29.07.2011 23:30, schrieb JL VT:
>                 > I don't know how fast Krita is in the other branches
>                 (I haven't tested)
>                 > however I'd like to ask if there's a good date to
>                 start feeling really
>                 > worried about speed?, I don't want 2.4 to be a
>                 single bit slower than
>                 > 2.3, so I'd like to start hacking to try to find
>                 where our current
>                 > bottlenecks are; but I don't know which parts deep
>                 in Krita to touch
>                 > without stepping on other developer's toes,
>                 moreover, my fears may be
>                 > unfounded, maybe we're just a couple weeks shy of a
>                 branch merge solving
>                 > all these problems, but, again, I haven't kept up
>                 enough with our IRC
>                 > backlogs and Krita branches to be sure.
>                 >
>                 > Should I be worried?.
>                 >
>                 > Is there an upcoming branch I should be testing to
>                 help with the speed
>                 > bottlenecks instead?.
>                 >
>
>                 As far as I know we have two big bottle necks.
>                 The first is the creation and transformation
>                 (rotation, scaling) of the
>                 brush masks. The last time I profiled krita it spent
>                 20-30% (I can't
>                 remember exactly anymore) of the whole processing time
>                 while painting
>                 with this operations.
>
>
>
>             Depends on which brush is used. Autobrush shows about 30%
>             of the time in processing the mask, but it's not using
>             100% cpu. I think there is another bottleneck that
>             callgrind doesn't show. Painting with predefined brushes
>             shows a big performance bottleneck in scaling the brush
>             (callgrind file:
>             http://depot.tu-dortmund.de/get/syvg6 ) in the stroke
>             benchmark. There is a single method that takes most of the
>             time, so that should be the first target when trying to
>             speed up things.
>
>
>         I have attached a patch that turns off interpolation. It
>         should give about double the performance when painting with
>         predefined brushes. Can the artists here check how big the
>         impact on quality is?
>
>
>     As first tested showed that it my patch also reduces some
>     artifacts too, I have commited it. Please check out if it's ok. If
>     not I will revert it.
>
>     _______________________________________________
>     kimageshop mailing list
>     kimageshop at kde.org <mailto:kimageshop at kde.org>
>     https://mail.kde.org/mailman/listinfo/kimageshop
>
>
>
> _______________________________________________
> kimageshop mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20110803/7b2feac0/attachment.html>