broken backwards compatibility
Boudewijn Rempt
boud at valdyas.org
Thu Apr 28 15:43:33 CEST 2011
On Thursday 28 April 2011 Apr, Cyrille Berger Skott wrote:
> On Thursday 28 April 2011, Boudewijn Rempt wrote:
> > I tried loading the Wasted Mutants showcase file in Krita today and
> > discovered that it doesn't look like the original version on krita.org
> > anymore... Maybe that's because the background gradient layer was
> > disabled, but I fear we have a regression here. Animtim, can you check?
> It is probably related to this unit test failure:
> http://my.cdash.org/testDetails.php?test=5883333&build=182488
>
> Since the file use the "screen" Composite op which now return totally different
> values:
> FAIL! : TestKoCompositeOps::testCompositeScreen() Compared values are not the
> same
> Actual (p16f1.red): 15014
> Expected ((quint16)18840): 18840
> Loc:
> [/home/cyrille/src/calligra/libs/pigment/tests/TestKoCompositeOps.cpp(1072)]
>
>
> And if you click on the "Alpha channel" icon for layer "21" then the file is
> fixed.
>
> My opinion is that the default value for "Alpha channel" should be inversed.
> Especially since it would give the same behaviour as in other applications.
Sounds like a sensible change then.
--
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org
More information about the kimageshop
mailing list