Patch for thumbnail update in layerbox

[Sven Langkamp]

On Sun, Sep 19, 2010 at 2:59 PM, Dmitry Kazakov <dimula73 at gmail.com> wrote:

>
>
> On Sun, Sep 19, 2010 at 4:56 PM, Sven Langkamp <sven.langkamp at gmail.com>wrote:
>
>> On Sun, Sep 19, 2010 at 2:53 PM, Dmitry Kazakov <dimula73 at gmail.com>wrote:
>>
>>>
>>>
>>> On Sun, Sep 19, 2010 at 4:41 PM, Sven Langkamp <sven.langkamp at gmail.com>wrote:
>>>
>>>> On Sun, Sep 19, 2010 at 2:28 PM, Boudewijn Rempt <boud at valdyas.org>wrote:
>>>>
>>>>> On Sunday 19 September 2010, Sven Langkamp wrote:
>>>>> > On Sun, Sep 19, 2010 at 2:20 PM, Boudewijn Rempt <boud at valdyas.org>
>>>>> wrote:
>>>>> >
>>>>> > > On Sunday 19 September 2010, Sven Langkamp wrote:
>>>>> > >
>>>>> > > > Yes, in some places we are still missing systemLocked. The
>>>>> layerbox can
>>>>> > > also
>>>>> > > > be used to find them ;)
>>>>> > >
>>>>> > > :-) But I don't think systemlocked makes sense for the freehand
>>>>> tool,
>>>>> > > especially since it will cause flicker of the toolbox on eveyr
>>>>> stroke
>>>>> > >
>>>>> >
>>>>> > You want it to update, but not to flicker? ;)
>>>>> > It can be changed by the timeout which is currently one second.
>>>>> >
>>>>>
>>>>> No, I'm not talking about the layerbox, I meant: doesn't
>>>>> setSystemLocked disable all the tools in the toolbox -- i.e., gray them out?
>>>>> If that happens on every stroke with the freehand tool the effect will be as
>>>>> distracting as the flickering of the paintop toolbar was after Adam's patch.
>>>>>
>>>>
>>>> Yes, they are grayed out. We could solve this by adding another
>>>> parameter that would block it for very short locks like tools.
>>>>
>>>
>>> I think adding parameters is the worst thing that we can do here =(
>>>
>>
>> For what reason?
>>
>
> Because it'll be pain to maintain.
>

I don't think so. We the the systemLocked everywhere anyway just to be sure
that is will not crash. An there wouldn't be less work to maintain it than
with an updated()

Attached patch with the parameter change.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100919/ba37588c/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nodechange2.diff
Type: text/x-patch
Size: 7485 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20100919/ba37588c/attachment-0001.diff