koffice/krita/image

[Dmitry Kazakov]

On Sun, Oct 3, 2010 at 10:45 AM, Cyrille Berger <> wrote:

> SVN commit 1182049 by berger:
>
> Fix: merging of layers with a different color space than their group layer
>
> BUG:247037
>
>
>  M  +1 -1      kis_image.cc
>
>
> --- trunk/koffice/krita/image/kis_image.cc #1182048:1182049
> @@ -708,7 +708,7 @@
>
>     KisPainter gc(mergedDevice);
>     gc.setChannelFlags(layer->channelFlags());
> -    gc.setCompositeOp(layer->compositeOp());
> +
>  gc.setCompositeOp(layer->colorSpace()->compositeOp(layer->compositeOp()->id()));
>     gc.setOpacity(layer->opacity());
>     gc.bitBlt(layerExtent.topLeft(), layer->projection(), layerExtent);
>


I think it would be much more obvious and safe to use:

gc.setCompositeOp(mergedDevice->colorSpace()->compositeOp(layer->compositeOpId()));

Especially, taking into account the fact, that colorspaces of the
mergedDevice and the layer may easily not coincide.


-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20101003/9caabad8/attachment.htm