Patch to fix selection test and mask extent

[Dmitry Kazakov]

Hmm.. I've added these functions just recently:
http://websvn.kde.org/?view=revision&revision=1099644

The logic was the following:

extent() - is the area where the node has an influence on the result image.
In other words, it is an area, where we should update when the layer changes
it's visibility.

KisMask::extent() - works right this way. It tells the area, where selection
is. And this is right for most of the masks, except of the transparency
mask. A transparency mask changes the entire image, except of the selection.
It means that we should update everywhere, except of the selection. And if
we don't have parent, we can't do anything.

So, i think, you should fix KisSelectionTest instead to confirm this logic.
Or this logic is wrong somewhere?


On Wed, Mar 24, 2010 at 4:36 PM, Sven Langkamp <sven.langkamp at gmail.com>wrote:

> Hi,
>
> I have attached a patch to fix the KisSelectionTest. The problem was that
> the extent of a KisTransparencyMask without a parent is always an empty
> QRect,
> Now the code from KisMask is used that uses the selection extent when there
> is a selection.
>
> Can you have a look if that is correct?
>
>
> Sven
>
> _______________________________________________
> kimageshop mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>
>


-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100324/ed34f856/attachment.htm