Patch for deleting tiles when commands are deleted from the undo stack

Dmitry Kazakov dimula73 at gmail.com
Fri Mar 19 14:29:26 CET 2010


i'll take a look tonight.

On Fri, Mar 19, 2010 at 3:33 PM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Friday 19 March 2010, Cyrille Berger wrote:
> > On Friday 19 March 2010, Boudewijn Rempt wrote:
> > > On Friday 19 March 2010, Cyrille Berger wrote:
> > > > Hello,
> > > >
> > > > Currently when KisTransaction is deleted, the corresponding tiles are
> > > > not removed and are kept in memory. That patch takes care of deleting
> > > > the tiles.
> > > >
> > > > As far as I can see it works, and the test that were successful are
> > > > still successful (and the others still failing).
> > >
> > > Yesterday I was trying to fix KisTransactionTest -- didn't succeed, I
> > > don't know why redo works in krita but not in the test -- but the test
> > > did end. With your patch, after failing, KisTransactionTest hangs in a
> > > lock in KisTileHashTabletraits::deleteTile in KisMementoManager line
> > > 301.
> >
> > works for me, but while writing this patch, I had a similar problem that
> I
> > fixed by editing the deleteTile function, since it is a function in a
> > header, it is quiet possible that is not correctly recompiled, can you
> try
> > a make clean in krita/image, and try again ?
>
> Sure!
>
> --
> Boudewijn Rempt | http://www.valdyas.org
> _______________________________________________
> kimageshop mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>



-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100319/d239bc70/attachment.htm 


More information about the kimageshop mailing list