Patch for deleting tiles when commands are deleted from the undo stack

Cyrille Berger cberger at cberger.net
Fri Mar 19 12:10:30 CET 2010


On Friday 19 March 2010, Boudewijn Rempt wrote:
> On Friday 19 March 2010, Cyrille Berger wrote:
> > Hello,
> > 
> > Currently when KisTransaction is deleted, the corresponding tiles are not
> > removed and are kept in memory. That patch takes care of deleting the
> > tiles.
> > 
> > As far as I can see it works, and the test that were successful are still
> > successful (and the others still failing).
> 
> Yesterday I was trying to fix KisTransactionTest -- didn't succeed, I don't
> know why redo works in krita but not in the test -- but the test did end.
> With your patch, after failing, KisTransactionTest hangs in a lock in
> KisTileHashTabletraits::deleteTile in KisMementoManager line 301.
works for me, but while writing this patch, I had a similar problem that I 
fixed by editing the deleteTile function, since it is a function in a header, 
it is quiet possible that is not correctly recompiled, can you try a make 
clean in krita/image, and try again ?

-- 
Cyrille Berger


More information about the kimageshop mailing list